Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: Facet field options enum style fix #101

Merged
merged 2 commits into from
Jun 24, 2022
Merged

style: Facet field options enum style fix #101

merged 2 commits into from
Jun 24, 2022

Conversation

adilansari
Copy link
Contributor

@adilansari adilansari commented Jun 24, 2022 •
edited
Loading

  • Updated enum to be all caps
  • Extracted error out of tigris exception
  • Renamed FacetFieldQueryOptions.limit to FacetFieldQueryOptions.size

adilansari
adilansari commented Jun 24, 2022
View reviewed changes
client/src/main/java/com/tigrisdata/db/client/config/TigrisConfiguration.java Outdated
.setAnnotationIntrospector(new TigrisAnnotationIntrospector())
.setAnnotationIntrospector(
new AnnotationIntrospectorPair(
new TigrisAnnotationIntrospector(), new JacksonAnnotationIntrospector()))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reason to disable Jackson annotations?

Copy link
Collaborator

@JigarJoshi JigarJoshi Jun 24, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We derive schema based off of the field name. and if user annotate their model with @JsonProperty to change the the field name under which the value will get serde. It will go out of sync.

@adilansari adilansari changed the title style: enum caps style: Facet field options enum style fix Jun 24, 2022
@adilansari adilansari force-pushed the search-improvements branch from 8e3a6c3 to 344f3e8 Compare June 24, 2022 16:20
@adilansari adilansari marked this pull request as ready for review June 24, 2022 16:22
@adilansari adilansari merged commit 12fb968 into main Jun 24, 2022
@adilansari adilansari deleted the search-improvements branch June 24, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JigarJoshi JigarJoshi JigarJoshi approved these changes

@himank himank himank approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adilansari @JigarJoshi @himank