Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add upgrade guide and update Readme for v1 #331

Merged
merged 38 commits into from
Nov 6, 2020
Merged

Add upgrade guide and update Readme for v1 #331

merged 38 commits into from
Nov 6, 2020

Conversation

bakerkretzmar
Copy link
Collaborator

@bakerkretzmar bakerkretzmar commented Sep 25, 2020 •
edited
Loading

No description provided.

@bakerkretzmar bakerkretzmar mentioned this pull request Oct 9, 2020
Closed
@bakerkretzmar bakerkretzmar changed the title Add upgrade guide Add upgrade guide and update Readme for v1 Oct 23, 2020
@bakerkretzmar
JavaScript → Javascript
837ccd5
@bakerkretzmar
Merge branch 'develop' into jbk/upgrading
49ee0b4
@bakerkretzmar
Wording/formatting
ae85598
@bakerkretzmar
Update Readme:
5960780 
- Move Usage above Setup
- Remove 'basic setup' section about @routes directive, it's covered in Installation
- Wording fixes
- Add note about boolean encoding (see #345)
- Remove old 'Artisan Command' section
@bakerkretzmar
Formatting
d83a956
@bakerkretzmar
Formatting and wording
5f2bd34
@bakerkretzmar bakerkretzmar marked this pull request as ready for review November 6, 2020 18:04
mattstauffer
mattstauffer requested changes Nov 6, 2020
View reviewed changes
Copy link
Member

@mattstauffer mattstauffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really fantastic work here. Just a few quick notes.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@bakerkretzmar bakerkretzmar merged commit e7a7d33 into develop Nov 6, 2020
@bakerkretzmar bakerkretzmar deleted the jbk/upgrading branch November 6, 2020 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattstauffer mattstauffer mattstauffer requested changes

Assignees
No one assigned
Labels
documentation in progress We're working on it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bakerkretzmar @mattstauffer