Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: deepen_to_t4 make bbox from mask image #202

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix: deepen_to_t4 make bbox from mask image #202

wants to merge 2 commits into from
+5 −2

Conversation

yamsam
Copy link

@yamsam yamsam commented Feb 5, 2025

Description

  1. This PR fixes the coordinate order when converting bbox from mask images.
  2. Additionally, it removes the directory before extracting the deepen annotation zip file. This fixes the issue where the target directory is overwritten when running the conversion process consecutively.

How to review

How to test

test data

test command



Reference



Notes for reviewer


    

  
  



      


          

          
  

    
  
    
    

  

  




          

        
      




  





       
            



      

  
        





      

  
          

  
  

  
      @yamsam
  yamsam


          requested review from
    Shin-kyoto and 
    ktro2828



    February 5, 2025 05:17    
    









      

  
        

  

      

  ktro2828
  

  
          

            
                  ktro2828
  

            

            approved these changes


            
                
                  Feb 7, 2025
                
            
            
          


          



              
    View reviewed changes
  


          





          

  
  
  
              

                        

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Collaborator


      

  


  

    

      @ktro2828

      
            ktro2828
  

      

      

      left a comment




      
    


  



                    

                        

  

  
 

  
    

    
Choose a reason for hiding this comment


    

      The reason will be displayed to describe this comment to others. Learn more.
    


    

      
      



  



  
    

      
LGTM

    

  
  




                      

                    
  

    
  
    
    

  

  




                        

                      
                    








      

  
  
  




  












  
  

    

      

  




    


    

      

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



      

    

  




  
          




      

  

    
    

    
  

    Reviewers
  


    


        

          

  
      @ktro2828
  
    ktro2828



          
            
              
            
          
          ktro2828 approved these changes

        

      

          

  
      @Shin-kyoto
  
    Shin-kyoto


                Awaiting requested review from Shin-kyoto


        
      


      






    

  


      
  

    Assignees
  



        

    No one assigned







      


  


  

    Labels
  



    

    None yet







      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    
      

        
    

    Development
  



          


Successfully merging this pull request may close these issues.



  


    
  




      

    

  
      

  

    

      2 participants
    

    

        
          @yamsam 
        
          @ktro2828