Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_control_msgs): add moderate stop interface service and message #88

Merged

Conversation

brkay54
Copy link
Contributor

@brkay54 brkay54 commented May 22, 2023

Related Links

Description

#82 (comment)
With this comment, we decided to add a new interface to make the vehicle stop while moving. Therefore, we want to add the new message and service files.

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Code is properly formatted
  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code is properly formatted
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR: Required to pass before the merge.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

…sage

Signed-off-by: Berkay Karaman <brkay54@gmail.com>
@brkay54
Copy link
Contributor Author

brkay54 commented May 23, 2023

@isamu-takagi Could you review this PR too, please? 🙏🏼

@isamu-takagi isamu-takagi self-requested a review May 23, 2023 05:49
Copy link
Contributor

@isamu-takagi isamu-takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brkay54
Copy link
Contributor Author

brkay54 commented May 23, 2023

@isamu-takagi Also I do not have write access to this repository. Can you merge it, please? 🙏🏼

@isamu-takagi isamu-takagi enabled auto-merge (squash) May 23, 2023 05:54
@isamu-takagi isamu-takagi merged commit be27ffa into tier4:tier4/universe May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants