Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_rtc_msgs): add new field to rtc cooperate status #148

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

go-sakayori
Copy link
Contributor

Related Links

https://github.com/orgs/autowarefoundation/discussions/4978

Description

This PR adds a new field requested in the CooperateStatus.msg.
The new field would be used to explicitly send a request for assistance to the operator.
For further detail refer to the related discussion.

Remarks

No regression as checked in TIER IV internal evaluator.

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Code is properly formatted
  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code is properly formatted
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR: Required to pass before the merge.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

Signed-off-by: Go Sakayori <go.sakayori@tier4.jp>
Signed-off-by: Go Sakayori <go.sakayori@tier4.jp>
@go-sakayori go-sakayori marked this pull request as ready for review September 18, 2024 12:28
Copy link
Collaborator

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@go-sakayori
Copy link
Contributor Author

@yukkysaito
I'm not authorized to merge this PR, so can you merge it?
Thank you in advance.

@yukkysaito yukkysaito merged commit a6d8211 into tier4/universe Sep 19, 2024
10 checks passed
@yukkysaito yukkysaito deleted the feat/add_field_to_rtc branch September 19, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants