Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tier4_system_msgs): add msgs for MRM pull over #115

Merged
merged 3 commits into from
Mar 22, 2024
Merged

feat(tier4_system_msgs): add msgs for MRM pull over #115

merged 3 commits into from
Mar 22, 2024

Conversation

mkuri
Copy link
Contributor

@mkuri mkuri commented Mar 22, 2024 •
edited
Loading

Related Links

autowarefoundation/autoware.universe#5634

Description

Add msgs for MRM pull over.

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Code is properly formatted
  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code is properly formatted
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR: Required to pass before the merge.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

mkuri added 2 commits March 22, 2024 13:58
@mkuri
feat(tier4_system_msgs): add msgs for MRM pull over
3959a75 
Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>
@mkuri
chore(tier4_system_msgs): add a newline
4ac6e31 
Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>
@mkuri mkuri requested a review from isamu-takagi March 22, 2024 05:02
isamu-takagi
isamu-takagi approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@isamu-takagi isamu-takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mitsudome-r mitsudome-r enabled auto-merge (squash) March 22, 2024 07:16
@mitsudome-r mitsudome-r mentioned this pull request Mar 22, 2024
Closed
7 tasks
@mitsudome-r
Copy link
Collaborator

Note: This PR was recreated from #108.

@mitsudome-r mitsudome-r disabled auto-merge March 22, 2024 07:30
@mitsudome-r mitsudome-r merged commit db7eef5 into tier4:tier4/universe Mar 22, 2024
9 checks passed
TomohitoAndo pushed a commit that referenced this pull request Mar 29, 2024
@mkuri @mitsudome-r @TomohitoAndo
feat(tier4_system_msgs): add msgs for MRM pull over (#115)
d905f32 
* feat(tier4_system_msgs): add msgs for MRM pull over

Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>

* chore(tier4_system_msgs): add a newline

Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>

---------

Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>
Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitsudome-r mitsudome-r mitsudome-r approved these changes

@isamu-takagi isamu-takagi isamu-takagi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkuri @mitsudome-r @isamu-takagi