Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rosbag_logging_mode #98

Merged
merged 1 commit into from
Apr 14, 2023

Conversation

1222-takeshi
Copy link
Contributor

@1222-takeshi 1222-takeshi commented Apr 14, 2023

PR Type

  • Improvement

Related Links

autoware_logging_suite repository (TIER IV INTERNAL LINK)

Description

Add rosbag_logging_mode to the node launched in external_api_adaptor.launch.py.

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding guidelines
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR / build-and-test-pr: Required to pass before the merge.
  • Build and test for PR / clang-tidy-pr: NOT required to pass before the merge. It is up to the reviewer(s).
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
@tkimura4 tkimura4 merged commit b4cb844 into tier4/universe Apr 14, 2023
@tkimura4 tkimura4 deleted the feat/add-rosbag-logging-mode branch April 14, 2023 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants