Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move api pkgs #7

Merged
merged 7 commits into from
Dec 17, 2021
Merged

Move api pkgs #7

merged 7 commits into from
Dec 17, 2021

Conversation

isamu-takagi
Copy link
Collaborator

@isamu-takagi isamu-takagi commented Dec 16, 2021

PR Type

  • Improvement

Related Links

autowarefoundation/autoware.universe#187
tier4/tier4_autoware_msgs#15
https://github.com/tier4/autoware.proj/pull/382 (remove api_msgs, add tier4_msgs)

Description

Move version message.
Move internal api packages.

Review Procedure

Check build success.

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding guidelines
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR / build-and-test-pr: Required to pass before the merge.
  • Build and test for PR / clang-tidy-pr: NOT required to pass before the merge. It is up to the reviewer(s).
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkimura4 tkimura4 merged commit a435326 into tier4/universe Dec 17, 2021
@tkimura4 tkimura4 deleted the move-api-pkgs branch December 17, 2021 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants