Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pacmod_interface): prevent gear chattering #64

Merged
merged 2 commits into from
Jul 14, 2023

Conversation

tkimura4
Copy link
Collaborator

@tkimura4 tkimura4 commented Jul 13, 2023

Description

image

Gear commands sent from Autoware may occasionally chatter, causing Pacmod to perform improper gear transitions. To address this issue, I add a feature to prevent gear chattering to the pacmod_driver.

Related Links

autowarefoundation/autoware.universe#4213
autowarefoundation/autoware.universe#4155

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
@tkimura4 tkimura4 requested review from shmpwk and 1222-takeshi July 13, 2023 10:49
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (689f93c) 0.00% compared to head (38798c9) 0.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #64   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         11      11           
  Lines        944     960   +16     
=====================================
- Misses       944     960   +16     
Flag Coverage Δ
differential 0.00% <0.00%> (?)
total ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nterface/src/pacmod_interface/pacmod_interface.cpp 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@1222-takeshi 1222-takeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@tkimura4 tkimura4 merged commit 664a58d into main Jul 14, 2023
@tkimura4 tkimura4 deleted the feat/avoid_gear_chattering branch July 14, 2023 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants