Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

fix(multi_object_tracker): update data association matrix #755

Merged
merged 3 commits into from
Feb 6, 2023

Conversation

zulfaqar-azmi-t4
Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 commented Feb 6, 2023

Signed-off-by: Muhammad Zulfaqar Azmi zulfaqar.azmi@tier4.jp

PR Type

  • Improvement

Related Links

TIER IV internal link : CAR

TIER IV internal link : Bike

TIER IV internal link : Slack

ego_v40_target_v60.mp4

autowarefoundation/autoware_launch#196

Description

In the scenario test, it was found that there are two cases, once involving CAR and another involving MOTORCYCLE, the incoming object are unable to be tracked.

Review Procedure

In the above scenario, the object can be detected.

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding guidelines
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR: Required to pass before the merge.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 marked this pull request as draft February 6, 2023 02:06
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 marked this pull request as ready for review February 6, 2023 03:56
Copy link
Collaborator

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…multi_object_tracker/data_association_matrix.param.yaml


also update for CAR->other objects

Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 merged commit 513d038 into awf-latest Feb 6, 2023
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 deleted the fix-update-data-association-matrix branch February 6, 2023 13:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants