This repository has been archived by the owner on Mar 27, 2023. It is now read-only.
fix velodyne launch #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry please do not merge now. I have a bit more modification items. |
|
It's ready for review. |
kenji-miyake
approved these changes
Mar 2, 2021
|
LGTM, but I'd like to wait for @wep21 's comment. |
|
Is it correct that the target branch is |
|
I've changed base branch. |
|
@wep21 @kenji-miyake |
|
@taichiH Can you rebase this PR on ros2-v0.9.0-beta? |
d95489a to
2dc1fe6
Compare
|
Change bese branch to v0.9.0 and resolve conflict. |
wep21
approved these changes
Mar 2, 2021
There was a problem hiding this comment.
LGTM
❯ ros2 launch sensing_launch velodyne_node_container.launch.py -s
Arguments (pass arguments as '<name>:=<value>'):
'model':
no description given
'launch_driver':
no description given
(default: 'True')
'calibration':
no description given
'device_ip':
no description given
(default: '192.168.1.201')
'scan_phase':
no description given
(default: '0.0')
'base_frame':
no description given
(default: 'base_link')
'container_name':
no description given
(default: 'velodyne_composable_node_container')
'min_range':
no description given
'max_range':
no description given
'pcap':
no description given
(default: '')
'port':
no description given
(default: '2368')
'read_fast':
no description given
(default: 'False')
'read_once':
no description given
(default: 'False')
'repeat_delay':
no description given
(default: '0.0')
'rpm':
no description given
(default: '600.0')
'laserscan_ring':
no description given
(default: '-1')
'laserscan_resolution':
no description given
(default: '0.007')
'num_points_thresholds':
no description given
(default: '300')
'invalid_intensity':
no description given
'frame_id':
no description given
(default: 'velodyne')
'gps_time':
no description given
(default: 'False')
'input_frame':
no description given
(default: LaunchConfig('base_frame'))
'output_frame':
no description given
(default: LaunchConfig('base_frame'))
'vehicle_param_file':
no description given
'vehicle_mirror_param_file':
no description given
❯ ros2 launch sensing_launch velodyne_VLP16.launch.xml -s
Arguments (pass arguments as '<name>:=<value>'):
'launch_driver':
no description given
(default: 'true')
'model':
no description given
(default: 'VLP16')
'calibration':
no description given
(default: FindPackageShare(pkg='velodyne_pointcloud') + '/params/VLP16db.yaml')
'max_range':
no description given
(default: '130.0')
'min_range':
no description given
(default: '0.4')
'invalid_intensity':
no description given
(default: '[0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0]')
'sensor_frame':
no description given
(default: 'velodyne')
'device_ip':
no description given
(default: '192.168.1.201')
'port':
no description given
(default: '2368')
'scan_phase':
no description given
(default: '0.0')
'vehicle_param_file':
no description given
'vehicle_mirror_param_file':
no description given
❯ ros2 launch sensing_launch velodyne_VLP32C.launch.xml -s
Arguments (pass arguments as '<name>:=<value>'):
'launch_driver':
no description given
(default: 'true')
'model':
no description given
(default: '32C')
'calibration':
no description given
(default: FindPackageShare(pkg='velodyne_pointcloud') + '/params/VeloView-VLP-32C.yaml')
'max_range':
no description given
(default: '200.0')
'min_range':
no description given
(default: '0.4')
'invalid_intensity':
no description given
(default: '[0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0]')
'sensor_frame':
no description given
(default: 'velodyne')
'device_ip':
no description given
(default: '192.168.1.201')
'port':
no description given
(default: '2368')
'scan_phase':
no description given
(default: '0.0')
'vehicle_param_file':
no description given
'vehicle_mirror_param_file':
no description given
❯ ros2 launch sensing_launch velodyne_VLS128.launch.xml -s
Arguments (pass arguments as '<name>:=<value>'):
'launch_driver':
no description given
(default: 'true')
'model':
no description given
(default: 'VLS128')
'calibration':
no description given
(default: FindPackageShare(pkg='velodyne_pointcloud') + '/params/VLS-128_FS1.yaml')
'max_range':
no description given
(default: '250.0')
'min_range':
no description given
(default: '0.5')
'invalid_intensity':
no description given
(default: '[0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0]')
'sensor_frame':
no description given
(default: 'velodyne')
'device_ip':
no description given
(default: '192.168.1.201')
'port':
no description given
(default: '2368')
'scan_phase':
no description given
(default: '0.0')
'vehicle_param_file':
no description given
'vehicle_mirror_param_file':
no description given
kosuke55
pushed a commit
that referenced
this pull request
Jan 17, 2023
Signed-off-by: GitHub <noreply@github.com> Signed-off-by: GitHub <noreply@github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>
This was referenced Jan 21, 2023
Merged
takayuki5168
pushed a commit
that referenced
this pull request
Jan 21, 2023
* add stop dist param * add keep stopping dist param
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed velodyne launch to pass vehicle_param_file and mirror_param_file.