Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

fix(simulator_launch): completely remove simulator_launch #706

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Jan 18, 2023

Signed-off-by: kminoda koji.minoda@tier4.jp

PR Type

  • Bug Fix

Related Links

Description

I mistakenly left one unnecessary file, which I should have removed here: tier4/autoware_launch#698

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding guidelines
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR: Required to pass before the merge.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda kminoda marked this pull request as ready for review January 18, 2023 02:58
@kminoda kminoda requested a review from yukkysaito January 18, 2023 02:58
Copy link
Collaborator

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants