This repository has been archived by the owner on Mar 27, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 38
Ros2 v0.8.0 fix packages #64
Merged
k0suke-murakami
merged 2 commits into
tier4:ros2-v0.8.0-beta
from
tkimura4:ros2-v0.8.0-fix-packages
Feb 24, 2021
Merged
Ros2 v0.8.0 fix packages #64
k0suke-murakami
merged 2 commits into
tier4:ros2-v0.8.0-beta
from
tkimura4:ros2-v0.8.0-fix-packages
Feb 24, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wep21
reviewed
Feb 24, 2021
@@ -18,6 +18,7 @@ | |||
<include file="$(find-pkg-share vehicle_launch)/launch/vehicle.launch.xml"> | |||
<arg name="vehicle_model" value="$(var vehicle_model)"/> | |||
<arg name="sensor_model" value="$(var sensor_model)"/> | |||
<arg name="vehicle_param_file" value="$(find-pkg-share $(var vehicle_model)_description)/config/vehicle_info.yaml"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vehicle_info.yaml
will be renamed at tier4/lexus_description.iv.universe#11. cc @kenji-miyake
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can create another PR after this is merged!
k0suke-murakami
approved these changes
Feb 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
kazuki527
pushed a commit
to kazuki527/autoware_launch
that referenced
this pull request
Apr 25, 2022
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
kosuke55
pushed a commit
that referenced
this pull request
Jan 17, 2023
* feat: add sync-universe-param-files Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix path Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix sync name Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * deal with review Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
This was referenced Jan 21, 2023
Merged
takayuki5168
pushed a commit
that referenced
this pull request
Jan 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add vehicle_param_file to simple_planning_simulator/lane_change_planner