This repository has been archived by the owner on Mar 27, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 38
added use_sim_time with AW_ROS2_USE_SIM_TIME envvar for the parameters in the *.launch.py #61
Merged
wep21
merged 4 commits into
ros2-v0.8.0-sensing-launch
from
ros2-v0.8.0-sensing-launch-use-sim-time
Feb 17, 2021
Merged
added use_sim_time with AW_ROS2_USE_SIM_TIME envvar for the parameters in the *.launch.py #61
wep21
merged 4 commits into
ros2-v0.8.0-sensing-launch
from
ros2-v0.8.0-sensing-launch-use-sim-time
Feb 17, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wep21
approved these changes
Feb 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
wep21
pushed a commit
that referenced
this pull request
Feb 22, 2021
…s in the *.launch.py (#61) * added use_sim_time with AW_ROS2_USE_SIM_TIME envvar for the parameters * changed to use EnvironmentVariable function for use_sim_time parameter * changed indent * removed an empty line Co-authored-by: hosokawa <hosokawa@sng-3f-ros2-eval.l.sng.tier4.jp>
k0suke-murakami
pushed a commit
that referenced
this pull request
Feb 24, 2021
* restore file name Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * Update livox_horizon.launch (#89) * fix pass through filter launch (#90) * fix pass through filter launch * change if statement style * update aip_x1 sensing launch (#100) * fix livox launch arg (#108) * add usb_cam depend (#118) * update aip_x1 camera.launch (#119) * update imu.launch (#120) * fix veodyne setting in aip_x1/lidar.launch (#125) * Add velodyne_monitor to velodyne_*.launch (#101) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Uupdate aip_x1 lidar.launch (#143) * Format gnss.launch (#145) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add use_gnss arg to aip_x1 gnss.launch (#146) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * support individual params (#137) * support individual params * remove kvaser_hardware_id.txt * Launch velodyne_monitor only when launch_driver is true (#163) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * [sensing_launch] ros2 porting: use container for livox point preprocessor Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * [sensing_launch] ros2-porting: fix vehicle_info params Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * Revert "restore file name" This reverts commit 37d7ac4. * [sensing_launch] ros2-porting: fix vehicle_info for livox preprocessor launch Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * [sensing_launch] ros2-porting: fix vehicle_info for api_** points_preprocessor.launch.py Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * fix launch Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * fix livox launch Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * added suffix ".xml" to "velodyne_monitor.launch" in the launch files * added use_sim_time with AW_ROS2_USE_SIM_TIME envvar for the parameters in the *.launch.py (#61) * added use_sim_time with AW_ROS2_USE_SIM_TIME envvar for the parameters * changed to use EnvironmentVariable function for use_sim_time parameter * changed indent * removed an empty line Co-authored-by: hosokawa <hosokawa@sng-3f-ros2-eval.l.sng.tier4.jp> * fixed typo on the arg bd_code_param_path lines (#63) Co-authored-by: hosokawa <hosokawa@sng-3f-ros2-eval.l.sng.tier4.jp> * [sensing_launch]: Fix indentation in gnss launch Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [sensing_launch]: Add missing dependency in package.xml Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [sensing_launch]: Fix velodyne launch Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [sensing_launch]: Fix livox launch Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [sensing_launch]: Add arg for vehicle parameter file in lidar launch Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [sensing_launch]: Cleanup Signed-off-by: Autoware <autoware@tier4.jp> * Add new line Signed-off-by: Autoware <autoware@tier4.jp> * [sensing_launch]: Add default config for xx1 Signed-off-by: Autoware <autoware@tier4.jp> * [sensing_launch]: Fix indentation Signed-off-by: Autoware <autoware@tier4.jp> Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com> Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: hiroyuki obinata <58019445+obi-t4@users.noreply.github.com> Co-authored-by: hosokawa <hosokawa@sng-3f-ros2-eval.l.sng.tier4.jp> Co-authored-by: HOSOKAWA Ikuto <hosokawa.ikuto@gmail.com> Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: Autoware <autoware@tier4.jp>
kazuki527
pushed a commit
to kazuki527/autoware_launch
that referenced
this pull request
Apr 25, 2022
Co-authored-by: prds1lg <prod-s1-github@tier4.jp>
kosuke55
pushed a commit
that referenced
this pull request
Jan 17, 2023
updates: - [github.com/pre-commit/pre-commit-hooks: v4.3.0 → v4.4.0](pre-commit/pre-commit-hooks@v4.3.0...v4.4.0) - [github.com/igorshubovych/markdownlint-cli: v0.31.1 → v0.32.2](igorshubovych/markdownlint-cli@v0.31.1...v0.32.2) - [github.com/pre-commit/mirrors-prettier: v2.7.1 → v3.0.0-alpha.4](pre-commit/mirrors-prettier@v2.7.1...v3.0.0-alpha.4) - [github.com/adrienverge/yamllint: v1.26.3 → v1.28.0](adrienverge/yamllint@v1.26.3...v1.28.0) - [github.com/psf/black: 22.6.0 → 22.10.0](psf/black@22.6.0...22.10.0) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This was referenced Jan 21, 2023
Merged
takayuki5168
pushed a commit
that referenced
this pull request
Jan 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRの種類
Jiraリンク
変更概要
レビュー方法
その他