Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

ci(autoware_launch): add a new workflow to update sync-param-files.yaml automatically #544

Merged
merged 2 commits into from
Nov 10, 2022

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Nov 10, 2022

Signed-off-by: Takayuki Murooka takayuki5168@gmail.com

PR Type

  • New Feature

Just copied autowarefoundation/autoware_launch#75 from awf/autoware_launch

Related Links

autowarefoundation/autoware_launch#66

Description

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding guidelines
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR: Required to pass before the merge.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

…ml automatically

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
kminoda
kminoda previously approved these changes Nov 10, 2022
Copy link
Contributor

@kminoda kminoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
(did not test the workflow, but seems fine given that this is just copied from awf/autoware_launch)

Copy link
Contributor

@kenji-miyake kenji-miyake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's sync the files! tier4/autoware_launch@3e25e29

@takayuki5168 takayuki5168 merged commit 4970669 into awf-latest Nov 10, 2022
@takayuki5168 takayuki5168 deleted the feat/update-sync-param-file-workflow branch November 10, 2022 07:40
@takayuki5168
Copy link
Contributor Author

It works
https://github.com/tier4/autoware_launch/pull/547/files

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants