Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

perception_launch: Traffic light composable nodes #43

Merged
merged 2 commits into from
Feb 18, 2021

Conversation

wep21
Copy link
Contributor

@wep21 wep21 commented Jan 12, 2021

Related PR

https://github.com/tier4/Pilot.Auto/pull/253

How to test

  • launch perception
    ros2 launch perception_launch perception.launch.xml mode:=lidar
  • clone traffic light dataset publisher(https://github.com/wep21/traffic_light_dataset_publisher) into your workspace and build
  • launch dataset publisher
    ros2 launch traffic_light_dataset_publisher traffic_light_dataset_publisher.launch.xml image_folder:=(your_download directory)/voclike_datasets_from_web_noncrop/train/JPEGImages label_folder:=(your_download directory)/voclike_datasets_from_web_noncrop/train/Annotations
  • echo traffic light state
    ros2 topic echo /perception/traffic_light_recognition/traffic_light_states
  • launch rqt image view and check debug image
    ros2 run rqt_image_view
    Screenshot from 2021-01-12 19-19-26
    Screenshot from 2021-01-12 20-34-12

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
@k0suke-murakami
Copy link
Contributor

Could you describe how to check this PR?

@wep21
Copy link
Contributor Author

wep21 commented Jan 12, 2021

@k0suke-murakami I've updated the description above. Please check and test.

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
@wep21
Copy link
Contributor Author

wep21 commented Feb 9, 2021

@TakaHoribe Have you already tested this?

@TakaHoribe
Copy link
Contributor

@wep21 I could see the debug images as shown in your post. Also noticed the perception.launch died with the following message while checking the data. I'm not sure this is ok or not.

[component_container-9] terminate called after throwing an instance of 'cv::Exception'
[component_container-9]   what():  OpenCV(4.2.0) ../modules/core/src/matrix.cpp:465: error: (-215:Assertion failed) 0 <= roi.x && 0 <= roi.width && roi.x + roi.width <= m.cols && 0 <= roi.y && 0 <= roi.height && roi.y + roi.height <= m.rows in function 'Mat'
[component_container-9] 
[ERROR] [component_container-9]: process has died [pid 152720, exit code -6, cmd '/opt/ros/foxy/lib/rclcpp_components/component_container --ros-args -r __node:=traffic_light_node_container -r __ns:=/perception/traffic_light_recognition'].

@wep21
Copy link
Contributor Author

wep21 commented Feb 9, 2021

@TakaHoribe Thank you for checking. I will try to find the cause of exception.

@TakaHoribe
Copy link
Contributor

@wep21 This happens every time. It may be the demo data contains invalid data, or the processing at the end of the demo data throws an exception.

@wep21 wep21 requested a review from TakaHoribe February 18, 2021 02:49
Copy link
Contributor

@TakaHoribe TakaHoribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Investigation for the exception problem could be later.

@TakaHoribe TakaHoribe merged commit 5fb3133 into tier4:ros2 Feb 18, 2021
kosuke55 pushed a commit that referenced this pull request Jul 8, 2022
updates:
- [github.com/tier4/pre-commit-hooks-ros: v0.7.0 → v0.7.1](tier4/pre-commit-hooks-ros@v0.7.0...v0.7.1)
- [github.com/scop/pre-commit-shfmt: v3.4.3-1 → v3.5.0-1](scop/pre-commit-shfmt@v3.4.3-1...v3.5.0-1)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
tzhong518 pushed a commit that referenced this pull request Aug 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants