Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

port vehicle_launch #4

Merged
merged 1 commit into from
Nov 17, 2020
Merged

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Oct 29, 2020

Description

porting vehicle_launch to ros2

Change xacro command:
<param name="robot_description" command="$(find xacro)/xacro --inorder $(arg model) to
<param name="robot_description" value="$(command 'xacro $(var model)
(--inorder option is default in ros2)

How to run

After tier4/lexus_description.iv.universe#4 is merged,

ros2 launch vehicle_launch vehicle.launch.xml sensor_model:=aip_xx1 vehicle_model:=lexus simulation:=true

Note Cannot run with simulation:=false since pacmod3 is not released for foxy.

@TakaHoribe TakaHoribe marked this pull request as ready for review November 6, 2020 14:19
@TakaHoribe
Copy link
Contributor Author

ready for review

@esteve esteve force-pushed the port-vehicle-launch branch from 5132426 to f5cd061 Compare November 13, 2020 16:05
@esteve
Copy link
Contributor

esteve commented Nov 13, 2020

@TakaHoribe I hope it's ok, I rebased your PR on top of ros2 to pick up the latest changes in the CI.

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@mitsudome-r mitsudome-r merged commit c16a475 into tier4:ros2 Nov 17, 2020
@TakaHoribe TakaHoribe deleted the port-vehicle-launch branch November 17, 2020 02:02
isamu-takagi added a commit that referenced this pull request Feb 7, 2022
isamu-takagi pushed a commit that referenced this pull request Feb 7, 2022
tier4-autoware-public-bot bot pushed a commit that referenced this pull request Apr 12, 2022
updates:
- [github.com/igorshubovych/markdownlint-cli: v0.30.0 → v0.31.1](igorshubovych/markdownlint-cli@v0.30.0...v0.31.1)
- [github.com/pre-commit/mirrors-prettier: v2.5.1 → v2.6.2](pre-commit/mirrors-prettier@v2.5.1...v2.6.2)
- [github.com/shellcheck-py/shellcheck-py: v0.8.0.3 → v0.8.0.4](shellcheck-py/shellcheck-py@v0.8.0.3...v0.8.0.4)
- [github.com/scop/pre-commit-shfmt: v3.4.2-1 → v3.4.3-1](scop/pre-commit-shfmt@v3.4.2-1...v3.4.3-1)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
kazuki527 referenced this pull request in kazuki527/autoware_launch Apr 25, 2022
takayuki5168 pushed a commit that referenced this pull request Mar 13, 2023
* fix(planning_launch): enable blind spot launch and change its params

* fix(planning_launch): change stop_margin param

* fix(planning_launch): revert stop_margin param
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants