Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

feat(planning_simulator): new parameters for lane change module #355

Merged
merged 9 commits into from
Aug 29, 2022
Merged

feat(planning_simulator): new parameters for lane change module #355

merged 9 commits into from
Aug 29, 2022

Conversation

zulfaqar-azmi-t4
Copy link
Contributor

Signed-off-by: Muhammad Zulfaqar Azmi zulfaqar.azmi@tier4.jp

PR Type

  • New Feature
  • Improvement

Related Links

autowarefoundation/autoware.universe#1139
autowarefoundation/autoware.universe#1140

Description

Previous lane change logic checks the distance between ego to the object using l2Norm. However, some information lost might occurs for example the object is on the left or right etc.

The lane change module is currently revised internally to better handle the dynamic environment. Instead of using l2norm, the distance is separated into lateral distance evaluation and longitudinal distance evaluation. the longitudinal distance evaluation takes into account of collision via predicted path.

This PR aims to add the configuration that is related to the realization of the newly revised functions.

Review Procedure

  1. rtc_auto_approval for right and left lane change needs to be disable
  2. Run the PSIM.
  3. Place ego starting position and goal. Goal must be on the adjacent lane to simulate lane change process.
  4. Place an object on the target lane.
    Screenshot from 2022-06-21 13-40-31
  5. If ego is within object vicinity and there is potential of collision via predicted path comparison, no path appears.
    Screenshot from 2022-06-21 13-41-26

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding guidelines
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR: Required to pass before the merge.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 marked this pull request as ready for review August 29, 2022 09:23
Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zulfaqar-azmi-t4
Copy link
Contributor Author

Thank you very much Wakabayashi-san!

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 merged commit 9cfb34d into tier4:awf-latest Aug 29, 2022
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 deleted the feat/lane-change-revised branch August 29, 2022 15:05
satoshi-ota pushed a commit that referenced this pull request Sep 7, 2022
* feat(planning_simulator): new parameters for lane change module

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* added publish debug marker

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* reorganize collision check

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* increase reaction time

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* Add longitudinal minimum threshold

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* Set constant color of path candidate to false

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* Remove parameters from lane_change.param.yaml

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* include abort parameters

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* set debug marker publisher to false

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants