This repository has been archived by the owner on Mar 27, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 38
feat(planning_simulator): new parameters for lane change module #355
Merged
zulfaqar-azmi-t4
merged 9 commits into
tier4:awf-latest
from
zulfaqar-azmi-t4:feat/lane-change-revised
Aug 29, 2022
Merged
feat(planning_simulator): new parameters for lane change module #355
zulfaqar-azmi-t4
merged 9 commits into
tier4:awf-latest
from
zulfaqar-azmi-t4:feat/lane-change-revised
Aug 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 21, 2022
Merged
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
shmpwk
approved these changes
Aug 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you very much Wakabayashi-san! |
Merged
satoshi-ota
pushed a commit
that referenced
this pull request
Sep 7, 2022
* feat(planning_simulator): new parameters for lane change module Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * added publish debug marker Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * reorganize collision check Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * increase reaction time Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Add longitudinal minimum threshold Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Set constant color of path candidate to false Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Remove parameters from lane_change.param.yaml Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * include abort parameters Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * set debug marker publisher to false Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Muhammad Zulfaqar Azmi zulfaqar.azmi@tier4.jp
PR Type
Related Links
autowarefoundation/autoware.universe#1139
autowarefoundation/autoware.universe#1140
Description
Previous lane change logic checks the distance between ego to the object using l2Norm. However, some information lost might occurs for example the object is on the left or right etc.
The lane change module is currently revised internally to better handle the dynamic environment. Instead of using l2norm, the distance is separated into lateral distance evaluation and longitudinal distance evaluation. the longitudinal distance evaluation takes into account of collision via predicted path.
This PR aims to add the configuration that is related to the realization of the newly revised functions.
Review Procedure
rtc_auto_approval
for right and left lane change needs to be disableRemarks
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks