Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

Rename some packages references #157

Merged
merged 7 commits into from
Dec 16, 2021

Conversation

1222-takeshi
Copy link
Contributor

PR Type

  • Improvement

Related Links

Description

rename some packages references.

  • autoware_global_parameter_loader -> global_parameter_loader
  • autoware_state_monitor -> ad_service_state_monitor
  • autoware_eror_monitor -> system_error_monitor
  • autoware_web_controller -> web_controller
  • autoware_api_msgs -> tier4_api_msgs

Review Procedure

Check that Psim is running.

ros2 launch autoware_launch planning_simulator.launch.xml map_path:=map_path sensor_model:=aip_xx1 vehicle_model:=lexus

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding guidelines
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR: Required to pass before the merge.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

@taikitanaka3
Copy link
Contributor

@1222-takeshi
can you fix pre-commit?

@taikitanaka3
Copy link
Contributor

note
this PR needs
autowarefoundation/autoware.universe#187

add ignore to

  • src/autoware/api_adaptor
  • src/autoware/universe/launch

Copy link
Collaborator

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

$ros2 launch autoware_launch planning_simulator.launch.xml vehicle_id:=default vehicle_model:=lexus sensor_model:=aip_xx1 map_path:=[MAP]

image

(run planning sim with tier4/tier4_ad_api_adaptor#6 )

@1222-takeshi 1222-takeshi merged commit c391b46 into tier4/universe Dec 16, 2021
@1222-takeshi 1222-takeshi deleted the rename-some-packages-references branch December 16, 2021 06:05
j4tfwm6z pushed a commit that referenced this pull request Feb 1, 2022
kazuki527 pushed a commit to kazuki527/autoware_launch that referenced this pull request Apr 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants