This repository has been archived by the owner on Mar 27, 2023. It is now read-only.
fix/add arg in order to disable dummy_perception_publisher from command line #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KeisukeShima
approved these changes
Nov 30, 2021
|
@satoshi-ota Could you explain why you want to change this in the description form, please? |
kazuki527
pushed a commit
to kazuki527/autoware_launch
that referenced
this pull request
Apr 25, 2022
chore: sync upstream
takayuki5168
pushed a commit
that referenced
this pull request
May 26, 2022
takayuki5168
pushed a commit
that referenced
this pull request
May 26, 2022
* fix/rviz perception config (#138) * auto/fix occupancy grid map topic name (#137) * fix/rename segmentation namespace (#139) * fix namespace: rviz config * fix namespace: planning stack * rename segmentatino directory * fix namespace: perception stack * fix/add arg in order to disable dummy_perception_publisher from command line (#144) Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
kosuke55
pushed a commit
that referenced
this pull request
Jan 17, 2023
* feat: update param path Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * organize param files Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
This was referenced Jan 21, 2023
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Related Links
Description
When we launch
logging_simulator.launch.xmlwith optionpercption:=true, no need to launchdummy_perception_publisher, and I want to be able to control enable/disabledummy_perception_publisherfrom the terminal without having to rewrite lauch file.Review Procedure
Remarks
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks