Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

Add elevation map loader to ground seg launch #136

Merged

Conversation

taichiH
Copy link
Contributor

@taichiH taichiH commented Nov 26, 2021

PR Type

  • Improvement

Related Links

Description

Update launch file to move elevation_map_loader from map_loader package to peception module.

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding guidelines
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR: Required to pass before the merge.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

@taichiH taichiH force-pushed the add-elevation-map-loader-to-ground-seg-launch branch from 12804dc to 5cbea4f Compare November 30, 2021 02:36
@taichiH taichiH marked this pull request as ready for review November 30, 2021 07:19
@taichiH taichiH force-pushed the add-elevation-map-loader-to-ground-seg-launch branch from 1465ffe to 91f99cf Compare December 2, 2021 06:58
@taichiH taichiH force-pushed the add-elevation-map-loader-to-ground-seg-launch branch from 91f99cf to ee8a0da Compare December 6, 2021 06:45
Copy link
Contributor

@satoshi-ota satoshi-ota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taichiH taichiH merged commit 498f86c into use-autoware-auto-msgs Dec 6, 2021
@taichiH taichiH deleted the add-elevation-map-loader-to-ground-seg-launch branch December 6, 2021 07:34
j4tfwm6z added a commit that referenced this pull request Feb 1, 2022
* Disable lidar temporarily

* Revert "Disable lidar temporarily"

This reverts commit 81359d412292b5396cef7aceb53909cb38cf1d95.

* Fix parameter for avoidance without foa (#134)

* Feature/add controller emergency param (#135)

* add controller_emergency_param

* add joy_controller_emergency_param_in_remote_control

* fix typo in autoware_error_monitor.param.yaml

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Co-authored-by: j4tfwm6z <proj-jpntaxi@tier4.jp>
Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
Co-authored-by: shiorikawata <73450134+shiorikawata@users.noreply.github.com>
kazuki527 pushed a commit to kazuki527/autoware_launch that referenced this pull request Apr 25, 2022
tzhong518 pushed a commit that referenced this pull request Aug 1, 2022
* chore: sync vehicle and sim param files

Signed-off-by: GitHub <noreply@github.com>

* chore: keep delay_compensation_time

Co-authored-by: satoshi-ota <satoshi-ota@users.noreply.github.com>
Co-authored-by: Shinnosuke Hirakawa <shinnosuke.hirakawa@tier4.jp>
kosuke55 pushed a commit that referenced this pull request Jan 17, 2023
* fix(autoware_launch): fix config path of system_error_monitor

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* fix typo again

Signed-off-by: kminoda <koji.minoda@tier4.jp>

Signed-off-by: kminoda <koji.minoda@tier4.jp>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants