Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

Fix remapping in control.launch.py #115

Merged
merged 2 commits into from
Nov 17, 2021
Merged

Conversation

rej55
Copy link
Contributor

@rej55 rej55 commented Nov 17, 2021

PR Type

  • Improvement

Related Links

Description

Fix control launch to run planning simulator.

TODO:
Fix remapping when external_cmd_selector and external_cmd_converter is ported

Review Procedure

Run planning simulator and check control modules does not die.

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding guidelines
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR: Required to pass before the merge.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

@rej55 rej55 requested review from TakaHoribe and tkimura4 November 17, 2021 03:23
@tkimura4
Copy link
Collaborator

tkimura4 commented Nov 17, 2021

/control/trajectory_follower/lateral_controller_node_exe
  Subscribers:
    /localization/kinematic_state: nav_msgs/msg/Odometry
    /parameter_events: rcl_interfaces/msg/ParameterEvent
    /planning/scenario_planning/trajectory: autoware_auto_planning_msgs/msg/Trajectory
    /vehicle/status/steering_status: autoware_auto_vehicle_msgs/msg/SteeringReport
  Publishers:
    /control/trajectory_follower/lateral/control_cmd: autoware_auto_control_msgs/msg/AckermannLateralCommand
    /control/trajectory_follower/lateral/diagnostic: autoware_auto_system_msgs/msg/Float32MultiArrayDiagnostic
    /control/trajectory_follower/lateral/predicted_trajectory: autoware_auto_planning_msgs/msg/Trajectory
    /parameter_events: rcl_interfaces/msg/ParameterEvent
    /rosout: rcl_interfaces/msg/Log
/control/trajectory_follower/longitudinal_controller_node_exe
  Subscribers:
    /localization/kinematic_state: nav_msgs/msg/Odometry
    /parameter_events: rcl_interfaces/msg/ParameterEvent
    /planning/scenario_planning/trajectory: autoware_auto_planning_msgs/msg/Trajectory
  Publishers:
    /control/trajectory_follower/longitudinal/control_cmd: autoware_auto_control_msgs/msg/LongitudinalCommand
    /control/trajectory_follower/longitudinal/diagnostic: autoware_auto_system_msgs/msg/Float32MultiArrayDiagnostic
    /control/trajectory_follower/longitudinal/slope_angle: autoware_auto_system_msgs/msg/Float32MultiArrayDiagnostic
    /parameter_events: rcl_interfaces/msg/ParameterEvent
    /rosout: rcl_interfaces/msg/Log
/control/trajectory_follower/latlon_muxer_node_exe
  Subscribers:
    /control/trajectory_follower/lateral/control_cmd: autoware_auto_control_msgs/msg/AckermannLateralCommand
    /control/trajectory_follower/longitudinal/control_cmd: autoware_auto_control_msgs/msg/LongitudinalCommand
    /parameter_events: rcl_interfaces/msg/ParameterEvent
  Publishers:
    /control/trajectory_follower/control_cmd: autoware_auto_control_msgs/msg/AckermannControlCommand
    /parameter_events: rcl_interfaces/msg/ParameterEvent
    /rosout: rcl_interfaces/msg/Log

/control/vehicle_cmd_gate
  Subscribers:
    /autoware/engage: autoware_auto_vehicle_msgs/msg/Engage
    /control/gate_mode_cmd: autoware_control_msgs/msg/GateMode
    /control/input/external/gear_cmd: autoware_auto_vehicle_msgs/msg/GearCommand
    /control/input/external/hazard_lights_cmd: autoware_auto_vehicle_msgs/msg/HazardLightsCommand
    /control/input/external/turn_indicators_cmd: autoware_auto_vehicle_msgs/msg/TurnIndicatorsCommand
    /control/shift_decider/gear_cmd: autoware_auto_vehicle_msgs/msg/GearCommand
    /control/trajectory_follower/control_cmd: autoware_auto_control_msgs/msg/AckermannControlCommand
    /external/selected/control_cmd: autoware_auto_control_msgs/msg/AckermannControlCommand
    /external/selected/heartbeat: autoware_external_api_msgs/msg/Heartbeat
    /parameter_events: rcl_interfaces/msg/ParameterEvent
    /planning/hazard_lights_cmd: autoware_auto_vehicle_msgs/msg/HazardLightsCommand
    /planning/turn_indicators_cmd: autoware_auto_vehicle_msgs/msg/TurnIndicatorsCommand
    /system/emergency/control_cmd: autoware_auto_control_msgs/msg/AckermannControlCommand
    /system/emergency/emergency_state: autoware_auto_system_msgs/msg/EmergencyState
    /system/emergency/gear_cmd: autoware_auto_vehicle_msgs/msg/GearCommand
    /system/emergency/hazard_lights_cmd: autoware_auto_vehicle_msgs/msg/HazardLightsCommand
    /vehicle/status/steering_status: autoware_auto_vehicle_msgs/msg/SteeringReport
  Publishers:
    /api/autoware/get/emergency: autoware_external_api_msgs/msg/Emergency
    /api/autoware/get/engage: autoware_auto_vehicle_msgs/msg/Engage
    /control/command/control_cmd: autoware_auto_control_msgs/msg/AckermannControlCommand
    /control/command/emergency_cmd: autoware_vehicle_msgs/msg/VehicleEmergencyStamped
    /control/command/gear_cmd: autoware_auto_vehicle_msgs/msg/GearCommand
    /control/command/hazard_lights_cmd: autoware_auto_vehicle_msgs/msg/HazardLightsCommand
    /control/command/turn_indicators_cmd: autoware_auto_vehicle_msgs/msg/TurnIndicatorsCommand
    /control/current_gate_mode: autoware_control_msgs/msg/GateMode
    /diagnostics: diagnostic_msgs/msg/DiagnosticArray
    /parameter_events: rcl_interfaces/msg/ParameterEvent
    /rosout: rcl_interfaces/msg/Log

@tkimura4
Copy link
Collaborator

tkimura4 commented Nov 17, 2021

ros2 topic echo /control/trajectory_follower/control_cmd -> OK.
ros2 topic echo /control/command/control_cmd -> OK.

Copy link
Collaborator

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rej55 rej55 merged commit 2610a6b into use-autoware-auto-msgs Nov 17, 2021
@rej55 rej55 deleted the auto/control_launch branch November 17, 2021 03:51
satoshi-ota pushed a commit that referenced this pull request Nov 26, 2021
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
j4tfwm6z pushed a commit that referenced this pull request Feb 1, 2022
* Add sync upstream develop

* Fix CI shell

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
kazuki527 pushed a commit to kazuki527/autoware_launch that referenced this pull request Apr 25, 2022
tzhong518 pushed a commit that referenced this pull request Aug 1, 2022
kosuke55 pushed a commit that referenced this pull request Jan 17, 2023
…115)

Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com>

Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants