This repository has been archived by the owner on Mar 27, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkimura4
reviewed
Nov 16, 2021
Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>
tkimura4
approved these changes
Nov 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
launcher側は~input/current_trajectory, .iv側はinput/current_trajectoryになっていたりするので、注意。
.iv側で型修正などとともにトピック名修正もお願いします。
satoshi-ota
pushed a commit
that referenced
this pull request
Nov 26, 2021
kazuki527
pushed a commit
to kazuki527/autoware_launch
that referenced
this pull request
Apr 25, 2022
* modify rviz panel (tier4#110) * add voltage * fix status panel * fix typo * fix system monitor diag (tier4#109) * tmp commit * some fix * comment out * add file and comment out Co-authored-by: prds1lg <prod-s1-github@tier4.jp> * behavior path planner: parameter tuning and some fix (tier4#108) * delete auto approval * update rviz * parameter tuning * update rviz * tuning tracking parameter * tuning avoidance * tuning obstacle avoidance * delete unused * change stop margin * parameter fix Co-authored-by: prds1lg <prod-s1-github@tier4.jp> * fix Random filter (tier4#114) * modify engage velocity + obstacle avoidance (tier4#113) * modify engage velocity * tuning avoidance * parameter tuning Co-authored-by: prds1lg <prod-s1-github@tier4.jp> * Fix heartbeat (tier4#126) (tier4#129) * fix: external_emergenxy_stop_heartbeat_timeout to 3.0 * feat: add heartbeat to meter panel * feat: use_external_emergency_stop to false in psim * fix: comment out * fix: change timeout sec Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> * fix: delete space * fix: delete space * fix: for pre-commit * fix: typo * fix typo Co-authored-by: prds1lg <prod-s1-github@tier4.jp> Co-authored-by: tier4-autoware-private-bot[bot] <87871706+tier4-autoware-private-bot[bot]@users.noreply.github.com>
kosuke55
pushed a commit
that referenced
this pull request
Jan 17, 2023
…113) Signed-off-by: ito-san <fumihito.ito@tier4.jp> Signed-off-by: ito-san <fumihito.ito@tier4.jp>
This was referenced Jan 21, 2023
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Related Links
Description
Fix launch files in control_launch to use trajectory follower nodes.
TODO:
Fix files in AAP.iv
Review Procedure
Remarks
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks