Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add far radar tracking and detection fusion pipeline #952

Merged
merged 8 commits into from
Oct 17, 2023

Conversation

YoshiRi
Copy link

@YoshiRi YoshiRi commented Oct 16, 2023

Description

動作確認テスト用ブランチです。
下記全ての変更を入れた場合のブランチでテストをしました。

動作を確認できているので全ての変更を入れてこのPRのfile diffがなくなることをもってCloseします。

下記のPRで足りないFix部分が含まれます。

下記のFixは後ほどawfにも入れるので差分はなくなるはず。

  • Fix commit
    • tracking_object_mergerのutilのincludeを整理
    • launcherの意図しない記述を修正

Related links

Tests performed

Perceptionの最終出力が出ることを確認

  • camera_lidar_fusion
  • camera_lidar_radar_fusion (detection)
  • camera_lidar_radar_fusion (tracking)

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

…r radar object and conventional lidar object (autowarefoundation#4340)

* init package: migrate from object merger

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* add node outline and check build passed

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* add util functions to interpolate tracked objs

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* add object merger function using interpolation

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* create object merger utils

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* add kinematics velocity merger

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* add association and merger

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* rename perception_utils to object_recognition_utils

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* add comment and complete main subscriber

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* add parameter control and rename some executable files

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* refactoring: fix apparent bugs

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* add debug tools to check association

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* temporary fix: radar tracker node name to anon

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* debug: data association tuning

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* rename copyright and add merger util function

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* add tracker_state and update association

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* update decorative tracker by using tracker_state

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* update system around measurement state function

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* fix radar object not merged problem

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* add existence probability control

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* create const function

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* change association settings depend on measurement and tracker state

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* fix association matrix

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* put hardcoded node parameter to yaml file

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* move tracker state parameter to yaml file

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* remove prediction failed objects

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* fix bug when none closest time sub objects found

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* add velocity diff gate in association

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* fix object interpolation problem

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* use fixed object interpolation

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* add README

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* add interpolated sub object publisher for debug

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* add debug message and fix interpolation

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* update README

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* fix unintended changes in radar tracking launch

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* add CmakeLists version

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* remove unnecessary debug description and type cast causes build warning

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* fix spell-check error

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* replace autoware_utils.hpp

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

---------

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
…acking stage (autowarefoundation#5269)

* update tracking/perception launch

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* switch tracker launcher mode with argument

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* update prediction to switch by radar_long_range_integration paramter

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* make radar far object integration switchable between detection/tracking

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* fix camera lidar radar fusion flow when 'tracking' is used.

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* fix spelling and appearance

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* reconstruct topic flow when use tracking to merge far object detection and near object detection

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* fix input topic miss in tracking.launch

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* fix comment in camera_lidar_radar fusion

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* refactor: rename and remove paramters in prediction.launch

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* refactor: rename merger control variable from string to bool

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

---------

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
@github-actions github-actions bot added documentation Improvements or additions to documentation launch perception labels Oct 16, 2023
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
@tkimura4
Copy link
Collaborator

image
utils.hppにdiffあり。確認中。

@tkimura4
Copy link
Collaborator

@YoshiRi
上のdiff取り込まなくてもtracking_object_mergerのビルドは通ったのですが、取り込む必要ありますか?

@YoshiRi
Copy link
Author

YoshiRi commented Oct 17, 2023

@tkimura4
ローカルで検証中ですが必要そうです 🙇

もう1点動作を検証したい箇所があってしばしお待ちいただけますか?

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
@YoshiRi YoshiRi changed the title (Test PR) chore: add radar tracking pipeline chore: add far radar tracking and detection fusion pipeline Oct 17, 2023
@YoshiRi YoshiRi requested a review from tkimura4 October 17, 2023 03:06
@YoshiRi YoshiRi marked this pull request as ready for review October 17, 2023 03:08
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Oct 17, 2023
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
@YoshiRi
Copy link
Author

YoshiRi commented Oct 17, 2023

psimの変更も追加で入れます ><
autowarefoundation#5326

…n#5326)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@YoshiRi YoshiRi deleted the chore/add_radar_tracking_pipeline branch October 17, 2023 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants