Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry pick bug fixes #75

Merged
merged 1 commit into from
Jun 27, 2022
Merged

chore: cherry pick bug fixes #75

merged 1 commit into from
Jun 27, 2022

Conversation

0x126
Copy link

@0x126 0x126 commented Jun 27, 2022

Description

cherry-pick

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

… data is 3 (#1162)

* fix(interpolation): fix spline interpolation when the num of input data is 3

Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>

* test(interpolation): add a random query test when size of base_keys is 3

Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>

* chore(interpolation): fix spell

Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>
@0x126 0x126 requested review from mkuri and TomohitoAndo June 27, 2022 07:18
@0x126 0x126 changed the title chore: cherry pick 1162 fix(interpolation): fix spline interpolation when the number of input data is 3 (#1162) Jun 27, 2022
@0x126 0x126 changed the title fix(interpolation): fix spline interpolation when the number of input data is 3 (#1162) chore: cherry pick bug fixes Jun 27, 2022
Copy link

@TomohitoAndo TomohitoAndo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0x126 0x126 merged commit 4217e53 into beta/v0.4.0 Jun 27, 2022
@0x126 0x126 deleted the chore/cherry-pick-1162 branch June 27, 2022 08:12
maxime-clem pushed a commit to maxime-clem/autoware.universe that referenced this pull request Feb 7, 2024
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants