Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(probablistic_occupancy_grid_map): add COLCON_IGNORE #642

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

h-ohta
Copy link

@h-ohta h-ohta commented Jul 5, 2023

Description

https://github.com/tier4/autoware_launch.x1.eve/pull/409
上記の対応によりこのパッケージの参照先がなくなったため、COLCON_IGNOREとする

Related links

https://tier4.atlassian.net/browse/AEAP-485

Tests performed

パッケージの参照先がCOLCON_IGNORE対象のパッケージを除いて存在しないことを確認した

COLCON_IGNORE対象

  • detected_object_validation
  • tier4_perception_launch
  • tier4_simulator_launch

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@h-ohta h-ohta marked this pull request as ready for review July 5, 2023 02:27
@h-ohta h-ohta requested review from yn-mrse and YoheiMishina July 5, 2023 02:39
Copy link

@YoheiMishina YoheiMishina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@yn-mrse yn-mrse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

buildの依存関係として特にこのパッケージに依存している別パッケージは存在しませんし、
launchの依存関係は https://github.com/tier4/autoware_launch.x1.eve/pull/409 で確認されているため問題ないと思われます。

@h-ohta h-ohta merged commit e60519c into beta/v0.3.16 Jul 5, 2023
@h-ohta h-ohta deleted the fix/ignore_probablistic branch July 5, 2023 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants