Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(map_based_prediction): use time_to_change_lane #510

Merged
merged 1 commit into from
May 23, 2023

Conversation

shmpwk
Copy link
Collaborator

@shmpwk shmpwk commented May 23, 2023

Description

lane_change_detectionを横移動量ベース(旧)からカットインまでの時間ベース(新)に変更

https://star4.slack.com/archives/C03S84LDJGG/p1684717842809799

Tests performed

psim/scenario sim (本来はコンポーネントチームでの実車試験後に適用するのが望ましいが、シミュレータで問題がないため適用)

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -13.56 ⚠️

Comparison is base (d7973a1) 13.55% compared to head (a4bdf2f) 0.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@               Coverage Diff               @@
##           beta/v0.8.0    #510       +/-   ##
===============================================
- Coverage        13.55%   0.00%   -13.56%     
===============================================
  Files              199       4      -195     
  Lines            18792     873    -17919     
  Branches         10299       0    -10299     
===============================================
- Hits              2547       0     -2547     
+ Misses           13307     873    -12434     
+ Partials          2938       0     -2938     
Flag Coverage Δ
differential 0.00% <0.00%> (-13.56%) ⬇️
Impacted Files Coverage Δ
...map_based_prediction/map_based_prediction_node.hpp 0.00% <ø> (ø)
...based_prediction/src/map_based_prediction_node.cpp 0.00% <0.00%> (ø)

... and 201 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@shmpwk shmpwk changed the title feat: use time_to_change_lane feat(map_based_prediction): use time_to_change_lane May 23, 2023
Copy link

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to your work.

@tkimura4 tkimura4 merged commit beae3dd into beta/v0.8.0 May 23, 2023
@tkimura4 tkimura4 deleted the feat/time_to_change_lane branch May 23, 2023 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants