Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(GNSS): add COLCON_IGNORE #396

Merged
merged 2 commits into from
May 9, 2023
Merged

Conversation

h-ohta
Copy link

@h-ohta h-ohta commented Apr 28, 2023

Description

Related Links

https://tier4.atlassian.net/browse/AEAP-485

Tests performed

$ cd ~/pilot-auto.x1.eve/src/autoware

# geo_pose_conv
$ grep . -r -e geo_pos_conv --exclude-dir .git -l
...

# gnss_poser
$ grep . -r -e gnss_poser --exclude-dir .git -l
...

より、autoware_launchおよびaip_laucnher側で参照されていないことを確認

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@h-ohta h-ohta changed the title chore(GNSS) add COLCON_IGNORE chore(GNSS): add COLCON_IGNORE Apr 28, 2023
@h-ohta h-ohta changed the base branch from beta/v0.3.15 to beta/v0.3.16 May 8, 2023 08:50
@h-ohta h-ohta marked this pull request as ready for review May 9, 2023 08:52
Copy link

@v-nojiri7841-esol v-nojiri7841-esol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

使用箇所がないことを確認いたしました。

以下のPRが先行してMerge済みであり、元々存在していた使用箇所は無くなっていることを確認済み。
https://github.com/tier4/aip_launcher.x1.eve/pull/20/files

@h-ohta h-ohta merged commit 79a6156 into beta/v0.3.16 May 9, 2023
@h-ohta h-ohta deleted the chore/colcon_ignore_gnss branch May 9, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants