Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_traffic_light_rviz_plugin): add COLCON_IGNORE #394

Merged
merged 3 commits into from
May 9, 2023

Conversation

h-ohta
Copy link

@h-ohta h-ohta commented Apr 28, 2023

Description

aip_x1ではカメラを搭載してないので信号認識はオフになっている
そのため、traffic_lightプラグインは不要なのでCOLCON_IGNOREを付与

Related Links

https://tier4.atlassian.net/browse/AEAP-485

Tests performed

以下のようにパッケージ指定でビルドした場合に見つからないようになること

$ cd ~/pilot-auto.x1.eve
$ colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release -DCMAKE_EXPORT_COMPILE_COMMANDS=ON --catkin-skip-building-tests --parallel-workers 8 --packages-up-to tier4_traffic_light_rviz_plugin
Package 'tier4_traffic_light_rviz_plugin' specified with --packages-up-to was not found

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@h-ohta h-ohta changed the base branch from beta/v0.3.15 to beta/v0.3.16 May 8, 2023 08:50
@h-ohta h-ohta marked this pull request as ready for review May 9, 2023 04:06
@h-ohta h-ohta changed the title chore(traffic_light_rviz_plugin): add COLCON_IGNORE feat(tier4_traffic_light_rviz_plugin): add COLCON_IGNORE May 9, 2023
Copy link

@m-iwashita-esol m-iwashita-esol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ツリーを確認し、tier4_traffic_light_rviz_pluginが使用されていない事を確認しました

@h-ohta h-ohta merged commit 7da79c7 into beta/v0.3.16 May 9, 2023
@h-ohta h-ohta deleted the h-ohta-patch-1 branch May 9, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants