Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add collision_checker #332

Merged
merged 6 commits into from
Apr 14, 2023
Merged

feat: add collision_checker #332

merged 6 commits into from
Apr 14, 2023

Conversation

0x126
Copy link

@0x126 0x126 commented Mar 21, 2023

Description

  • Added a new module for detecting collisions with objects
    • When an object is detected within a specific distance from the ego, it is considered a collision and outputs an ERROR diag

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@0x126 0x126 requested review from mkuri and TomohitoAndo March 21, 2023 08:23
@github-actions github-actions bot added documentation Improvements or additions to documentation system labels Mar 21, 2023
@0x126 0x126 marked this pull request as ready for review March 26, 2023 02:52
@0x126 0x126 force-pushed the feat/collision_checker branch from a067d7c to 1e68265 Compare March 26, 2023 02:52
@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2023

Codecov Report

❗ No coverage uploaded for pull request base (beta/v0.6.1@ccd1688). Click here to learn what that means.
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@              Coverage Diff               @@
##             beta/v0.6.1     #332   +/-   ##
==============================================
  Coverage               ?   10.57%           
==============================================
  Files                  ?     1248           
  Lines                  ?    90103           
  Branches               ?    20802           
==============================================
  Hits                   ?     9532           
  Misses                 ?    70484           
  Partials               ?    10087           
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.56% <0.00%> (?) Carriedforward from e5fb43e

*This pull request uses carry forward flags. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TomohitoAndo
Copy link

I confirmed this works.

collision_checker.mp4

@TomohitoAndo TomohitoAndo self-requested a review April 14, 2023 01:24
Copy link

@TomohitoAndo TomohitoAndo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0x126 0x126 merged commit 2e6f61e into beta/v0.6.1 Apr 14, 2023
@0x126 0x126 deleted the feat/collision_checker branch April 14, 2023 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants