Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(crosswalk): reduce processing time (#2137) #175

Merged

Conversation

tkimura4
Copy link
Collaborator

@tkimura4 tkimura4 commented Nov 10, 2022

Description

autowarefoundation#2137
Hotfix to beta/v0.5.2-odaiba3

[TIER IV INTERNAL LINK] https://tier4.atlassian.net/browse/T4PB-20946
reduce crosswalk module's processing time

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

* perf(crosswalk): use sparse resampled path

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* perf(crosswalk): create attention area all at once

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2022

Codecov Report

❗ No coverage uploaded for pull request base (beta/v0.5.2-odaiba3@ae02c41). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@                  Coverage Diff                  @@
##             beta/v0.5.2-odaiba3    #175   +/-   ##
=====================================================
  Coverage                       ?   4.75%           
=====================================================
  Files                          ?      80           
  Lines                          ?    6208           
  Branches                       ?    3332           
=====================================================
  Hits                           ?     295           
  Misses                         ?    5725           
  Partials                       ?     188           
Flag Coverage Δ
differential 4.75% <0.00%> (?)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tkimura4 tkimura4 merged commit e1a9339 into beta/v0.5.2-odaiba3 Nov 11, 2022
@tkimura4 tkimura4 deleted the hotfix/reduce-crosswalk-processing-time branch November 11, 2022 01:38
tkimura4 added a commit that referenced this pull request Nov 11, 2022
tkimura4 added a commit that referenced this pull request Nov 11, 2022
)" (#179)

Revert "perf(crosswalk): reduce processing time (autowarefoundation#2137) (#175)"

This reverts commit e1a9339.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants