feat(X2 performance tuning): merge pr about concatenate_data, downsample_filter, occupancy_grid_map #1289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ud topic name (autowarefoundation#6525) * feat: enable to change synchronized pointcloud message Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * fix: bug fix in topic name replace function Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * revert: revert changes do not related with this PR Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * chore: move topic rename function to class member Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> --------- Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
…clouds in sensor frame (autowarefoundation#6586) * feat: make concatenate node to publish pointclouds in sensor frame Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * chore: disable frame transform if not necessary Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> --------- Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
…towarefoundation#6138) * add pickup based voxel grid filter Signed-off-by: Yukihito Saito <yukky.saito@gmail.com> * style(pre-commit): autofix * add comment Signed-off-by: Yukihito Saito <yukky.saito@gmail.com> * add readme Signed-off-by: Yukihito Saito <yukky.saito@gmail.com> * add comment Signed-off-by: Yukihito Saito <yukky.saito@gmail.com> * Update sensing/pointcloud_preprocessor/include/pointcloud_preprocessor/downsample_filter/pickup_based_voxel_grid_downsample_filter.hpp Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com> * Update sensing/pointcloud_preprocessor/src/downsample_filter/pickup_based_voxel_grid_downsample_filter.cpp * style(pre-commit): autofix * tuning for processing time Signed-off-by: Yukihito Saito <yukky.saito@gmail.com> * change to robin_hood Signed-off-by: Yukihito Saito <yukky.saito@gmail.com> * style(pre-commit): autofix * fix: ignore cpplint for external file Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp> * fix cspell Signed-off-by: Yukihito Saito <yukky.saito@gmail.com> * style(pre-commit): autofix * fix cspell error Signed-off-by: Yukihito Saito <yukky.saito@gmail.com> --------- Signed-off-by: Yukihito Saito <yukky.saito@gmail.com> Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com> Co-authored-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
…to ogm creation (autowarefoundation#6865) * feat: add downsample filter to ogm creation Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * feat: add downsample to multi_lidar ogm creation Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * chore: update package.xml and readme and param file Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * chore: update readme document Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * chore: fix downsample size Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * chore: fix cspell error Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * feat: add test_depend Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> --------- Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
…ation for pointcloud pipeline (autowarefoundation#6056)
…it (autowarefoundation#6843) * provide only one warning Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * associate only one time Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * Revert "associate only one time" This reverts commit 984d028. * remove redundant for loop and rclcpp::Time instantiation Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> --------- Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
badai-nguyen
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains experimental settings.
Related links
Tests performed
Notes for reviewers
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.