Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: display hazard status that has no hardware_id #1288

Merged
merged 1 commit into from
May 10, 2024

Conversation

TomohitoAndo
Copy link

@TomohitoAndo TomohitoAndo commented May 10, 2024

Description

⚠️ This modification is only applied to this branch.

MRM Summary was not displayed when using the diagnostic graph aggregator because the hazard status message has no hardware_id.
So I fixed to display the hazard_status that has no hardware_id.

Tests performed

PSim
image

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
@TomohitoAndo TomohitoAndo marked this pull request as ready for review May 10, 2024 05:33
@TomohitoAndo TomohitoAndo requested a review from kminoda as a code owner May 10, 2024 05:33
@TomohitoAndo TomohitoAndo requested review from 0x126 and saka1-s and removed request for kminoda May 10, 2024 05:33
@TomohitoAndo TomohitoAndo merged commit 6fb0beb into beta/v0.19.1 May 10, 2024
18 of 19 checks passed
@TomohitoAndo TomohitoAndo deleted the update-mrm-rviz-plugin branch May 10, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants