Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_system_launch): add option to launch mrm handler (#6660) #1214

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

TomohitoAndo
Copy link

@TomohitoAndo TomohitoAndo commented Mar 28, 2024

Description

This PR adds the option to launch mrm handler.
Cherry-pick following PR.

Related links:

Tests performed

planning simulator
I confirmed Emergency Stop and Comfortable Stop was performed when corresponding diagnostics was published.

Emergency Stop

emergency_stop.mp4

Comfortable Stop

comfortable_stop.mp4

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

isamu-takagi and others added 2 commits March 29, 2024 17:31
… on running mode (autowarefoundation#6700)

chore(tier4_system_launch): add option of using graph path for simulation

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
@TomohitoAndo TomohitoAndo force-pushed the feat/launch-mrm-handler branch from 76fa197 to 4037478 Compare March 29, 2024 11:03
@TomohitoAndo TomohitoAndo marked this pull request as ready for review March 29, 2024 11:28
@TomohitoAndo TomohitoAndo requested review from mkuri and 0x126 and removed request for ito-san and TetsuKawa March 29, 2024 11:28
@TomohitoAndo
Copy link
Author

I confirmed Comfortable stop was performed when use_comfortable_stop is set to true in this PR. See "Tests Performed" for the details.

Copy link

@mkuri mkuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomohitoAndo TomohitoAndo merged commit 26e690e into beta/v0.19.1 Apr 2, 2024
26 of 27 checks passed
@TomohitoAndo TomohitoAndo deleted the feat/launch-mrm-handler branch April 2, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants