Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(traffic_light_multi_camera_fusion): take confidence into consideration(#6267) #1155

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

tzhong518
Copy link

@tzhong518 tzhong518 commented Feb 21, 2024

Description

Cherry-pick this PR to avoid mistrial resulted from low-confidence misdetection.
autowarefoundation#6267

Related

https://tier4.atlassian.net/browse/RT1-4749

Tests performed

see autowarefoundation#6267

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…ration (autowarefoundation#6267)

* fix: highest confidence

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix: use the confidence of the first element

Signed-off-by: tzhong518 <sworgun@gmail.com>

---------

Signed-off-by: tzhong518 <sworgun@gmail.com>
@shmpwk
Copy link
Collaborator

shmpwk commented Feb 21, 2024

@tzhong518
Thank you for your PR.
I will merge this into beta/v0.20.1.2 which is the next minor version.
When beta/v0.20.1.2 is created, I will change the merging branch of this PR.

@shmpwk
Copy link
Collaborator

shmpwk commented Feb 21, 2024

@tzhong518
Could you also write cherry-pick list spreadsheet for v0.44.2.0?
https://docs.google.com/spreadsheets/d/1RrbuzzCZ3m6HQtcUdU-3ZPi4GtLL1uS7qCNJy53vDjg/edit#gid=1916105067

@shmpwk shmpwk self-assigned this Feb 26, 2024
@shmpwk shmpwk changed the base branch from beta/v0.20.1.1 to beta/v0.20.1.2 February 28, 2024 05:17
Copy link
Collaborator

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shmpwk shmpwk merged commit d9c5e3d into beta/v0.20.1.2 Mar 4, 2024
19 checks passed
@shmpwk shmpwk deleted the cherry-pick/beta/v0.20.1.1+tlr_fusion branch March 4, 2024 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants