Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner): update behavior path planner #1095

Merged
merged 12 commits into from
Jan 18, 2024

Conversation

kosuke55
Copy link

@kosuke55 kosuke55 commented Jan 17, 2024

Description

avoidance + goal planner連携周りの変更がメイン。
start plannerも注目物体の可視化マーカーを追加

Related links

Tests performed

psim, snceario in main branch

scenario test in xx1
https://evaluation.tier4.jp/evaluation/reports/4e6fe486-78c4-54a0-b552-b3aaf5838a69?project_id=prd_jt
(〜feat(goal_planner): exclude goals located laterally in no_parking_are…
4ab68fa)

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

kosuke55 and others added 10 commits January 17, 2024 14:34
* fix(motion_utils): add guard to calcCurvature

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* style(pre-commit): autofix

---------

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
)

* feat(start_planner): output objects of interest

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* style(pre-commit): autofix

---------

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…warefoundation#6068)

* feat(goal_planner): add scale buffer to calcModuleRequestLength

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* style(pre-commit): autofix

---------

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* pref(avoidance): don't use boost union_

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* perf(avoidance): reduce frequency to call calcSignedArcLength

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* perf(turn_signal): reduce frequency to call calcSignedArcLength

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* perf(static_drivable_area_expansion): don't use calcDistance2d

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(static_drivable_area_expansion): rename and fix return value consistency

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…t endless loop (autowarefoundation#6084)

* perf(avoidance): reduce heavy process

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(avoidance): filter objects by precise lon distance

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* refactor(avoidance): remove unused function

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(avoidance): improve detection area

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(avoidance): return shift line

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…neously (autowarefoundation#5979)

* feat(avoidance/goal_planner): execute avoidance and pull over simultaneously

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* use utils

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix overlapped

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* reafactor(behavior_path_planner): move isAllowedGoalModification to common

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix readme

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* add goal modification condtion to avoidance

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* clean up

* revert param

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix param

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* move dead line process

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix condition

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix crop

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix crop

* fix typos

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

---------

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Copy link
Collaborator

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

satoshi-ota and others added 2 commits January 18, 2024 10:49
…efoundation#6097)

* fix(avoidance): fix invalid vector access

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(avoidance): fix detection area

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@shmpwk
Copy link
Collaborator

shmpwk commented Jan 18, 2024

LGTMAGAIN

@kosuke55 kosuke55 merged commit a2908c0 into beta/v0.20.1 Jan 18, 2024
15 of 16 checks passed
@kosuke55 kosuke55 deleted the feat/update_bpp_v0.20.1 branch January 18, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants