Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bvp): traffic light state debug #1083

Merged
merged 1 commit into from
Jan 22, 2024
Merged

fix(bvp): traffic light state debug #1083

merged 1 commit into from
Jan 22, 2024

Conversation

mehmetdogru
Copy link

Description

  • In bvp modifyPathVelocity function returns early without updating looking_tl_state_ which is causing the traffic light debug msg is not being up to date
  • looking_tl_state_ is not cleared in cases no traffic light info message is available, so debug msg keeps sending the latest value

Related links

TIER IV INTERNAL LINK

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

fix(bvp): traffic light state debug
ea508f0 
Signed-off-by: Mehmet Dogru <mdogru@leodrive.ai>
@mehmetdogru mehmetdogru force-pushed the md-leo/fix-traffic-light-state-debug branch from 2b9ce29 to ea508f0 Compare December 29, 2023 07:03
@mehmetdogru mehmetdogru changed the title fix traffic light state debug fix(bvp): traffic light state debug Dec 29, 2023
@mehmetdogru
Copy link
Author

cc: @shmpwk

shmpwk
shmpwk approved these changes Dec 29, 2023
View reviewed changes
Copy link
Collaborator

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomohitoAndo
Copy link

Thank you for the fix!
Since beta/v0.11.1 is already fixed, I will change the base branch when the new beta branch is created.
Let me change this PR to draft until then to prevent unintended merge 🙏

@TomohitoAndo TomohitoAndo marked this pull request as draft December 29, 2023 08:12
@TomohitoAndo TomohitoAndo changed the base branch from beta/v0.11.1 to beta/v0.11.2 January 18, 2024 05:27
@TomohitoAndo TomohitoAndo marked this pull request as ready for review January 22, 2024 09:16
@TomohitoAndo
Copy link

I confirmed /awapi/traffic_light/get/nearest_traffic_signal is published when using V2I.
LGTM!

image

@TomohitoAndo TomohitoAndo merged commit fcc11e1 into tier4:beta/v0.11.2 Jan 22, 2024
13 of 14 checks passed
TomohitoAndo pushed a commit that referenced this pull request Feb 19, 2024
@mehmetdogru @TomohitoAndo
fix(bvp): traffic light state debug (#1083)
f9b2bac 
Signed-off-by: Mehmet Dogru <mdogru@leodrive.ai>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
TomohitoAndo added a commit that referenced this pull request Feb 19, 2024
@TomohitoAndo
fix(bvp): traffic light state debug (#1083)
c36c197 
Signed-off-by: Mehmet Dogru <mdogru@leodrive.ai>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
@TomohitoAndo TomohitoAndo mentioned this pull request Feb 19, 2024
Merged
4 tasks
saka1-s added a commit that referenced this pull request Mar 11, 2024
@saka1-s @satoshi-ota
@kminoda @TomohitoAndo @pre-commit-ci @maxime-clem @takeshi-iwanari @YoshiRi @soblin @YamatoAndo @0x126 @SakodaShintaro @mehmetdogru @rej55 @kyoichi-sugahara
feat: keep stop policy v0.11.2 (#1125)
23d651f 
* feat(avoidance): keep stopping until all shift lines are registered

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(map_loader): display curbstone as marker array (autowarefoundation#4958)

display curbstone as marker array

Signed-off-by: Shohei Sakai <saka1s.jp@gmail.com>
Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>

* revert refactoring due to cherry-pick

* feat(ndt_scan_matcher): use glog (autowarefoundation#5465) (#1031)

* feat(ndt_scan_matcher): use glog



* style(pre-commit): autofix

* update



* style(pre-commit): autofix

---------

Signed-off-by: kminoda <koji.minoda@tier4.jp>
Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* feat(out_of_lane): improve reuse of previous decision (#1017)

* Do not directly reuse a prev stop point but project it on the new path

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* Improve reuse of the previously inserted stop point

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* Fix precision of inserted stop point

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

---------

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* fix(system_monitor): output command line (autowarefoundation#5430) (#1057)

* fix(system_monitor): output command line



* style(pre-commit): autofix

---------

Signed-off-by: takeshi.iwanari <takeshi.iwanari@tier4.jp>
Co-authored-by: takeshi-iwanari <takeshi.iwanari@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* chore: pull tracking object merger from awf/main

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* feat(intersection): check path margin for overshoot vehicles on red light (autowarefoundation#5394) (#1056)

Co-authored-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* fix(ndt_scan_matcher): delete diagnostics thread (autowarefoundation#5532)

Signed-off-by: yamato-ando <Yamato ANDO>
Co-authored-by: yamato-ando <Yamato ANDO>

* fix(ndt_scan_matcher): delete unmerged feature

* fix(ndt_scan_matcher): fixed a lock scope in update_ndt (autowarefoundation#5951)

Fixed the lock scope in update_ndt

Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp>

* fix(static_drivable_area_expansion): fix bug in expansion logic for hatched road marking (autowarefoundation#5842) (#1075)

fix(utils): fix drivable area expansion logic for zebra zone

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(bvp): traffic light state debug (#1083)

Signed-off-by: Mehmet Dogru <mdogru@leodrive.ai>

* fix(traffic_light): stop if the traffic light signal timed out (autowarefoundation#5819) (#1124)

* fix(traffic_light): stop if the traffic light signal timed out



* fix(traffic_light): fix README format



---------

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>

* refactor(mpc_lateral_controller): add debug info of qp solver (autowarefoundation#5459) (#1098)

* add debug info of qp solver



* no info for EigenLeastSquareLLT



* return 0 in base class

---------

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Co-authored-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: Shohei Sakai <saka1s.jp@gmail.com>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: takeshi.iwanari <takeshi.iwanari@tier4.jp>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yamato-ando <Yamato ANDO>
Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp>
Signed-off-by: Mehmet Dogru <mdogru@leodrive.ai>
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Co-authored-by: satoshi-ota <satoshi.ota928@gmail.com>
Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
Co-authored-by: Tomohito ANDO <tomohito.ando@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Maxime CLEMENT <78338830+maxime-clem@users.noreply.github.com>
Co-authored-by: takeshi-iwanari <takeshi.iwanari@tier4.jp>
Co-authored-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Co-authored-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Co-authored-by: Yamato Ando <yamato.ando@gmail.com>
Co-authored-by: Shinnosuke Hirakawa <shinnosuke.hirakawa@tier4.jp>
Co-authored-by: SakodaShintaro <shintaro.sakoda@tier4.jp>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
Co-authored-by: Mehmet Dogru <48479081+mehmetdogru@users.noreply.github.com>
Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
Co-authored-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
yhisaki added a commit that referenced this pull request Jan 31, 2025
@yhisaki
fix(bvp): traffic light state debug
e5171d7 
This commit corresponds to #1083.

Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
tier4-githubadmin pushed a commit that referenced this pull request Feb 3, 2025
@yhisaki @actions-user
fix(bvp): traffic light state debug
52cb0bb 
This commit corresponds to #1083.

Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
tier4-githubadmin pushed a commit that referenced this pull request Feb 4, 2025
@yhisaki @actions-user
fix(bvp): traffic light state debug
6246520 
This commit corresponds to #1083.

Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
tier4-githubadmin pushed a commit that referenced this pull request Feb 4, 2025
@yhisaki @actions-user
fix(bvp): traffic light state debug
785e5fc 
This commit corresponds to #1083.

Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
yhisaki added a commit that referenced this pull request Feb 6, 2025
@yhisaki
fix(bvp): traffic light state debug
2a724a8 
This commit corresponds to #1083.

Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomohitoAndo TomohitoAndo TomohitoAndo approved these changes

@shmpwk shmpwk shmpwk approved these changes

@satoshi-ota satoshi-ota Awaiting requested review from satoshi-ota satoshi-ota is a code owner

@tkimura4 tkimura4 Awaiting requested review from tkimura4 tkimura4 is a code owner

@yuki-takagi-66 yuki-takagi-66 Awaiting requested review from yuki-takagi-66

Assignees
No one assigned
Labels
planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mehmetdogru @TomohitoAndo @shmpwk