Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(image_projection_based_fusion,lidar_centerpoint): add cuda preprocess #1041

Merged
merged 5 commits into from
Nov 27, 2023

Conversation

tkimura4
Copy link
Collaborator

Description

autowarefoundation#5681
Hotfix to beta/v0.10.6

This pull request refactors and optimizes the code for the pointpainting fusion and centerpoint algorithms for 3D object detection. It introduces new CUDA functions and kernels for voxel generation and feature extraction, and improves the memory management and performance of the existing ones. It also renames and modifies some functions and classes to better reflect their functionality and simplify their interface. The main files affected are pointpainting_trt.hpp, preprocess_kernel.cu, voxel_generator.cpp, and centerpoint_trt.cpp.

Related links

autowarefoundation#5681

Tests performed

I've tested with rosbag and standalone launch file.
I've confirmed the pre-processing time decreases after implementing this PR.

Notes for reviewers

Interface changes

none

Effects on system behavior

It improves the memory management and performance of the existing ones

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

wep21 and others added 5 commits November 27, 2023 10:46
Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
@tkimura4 tkimura4 requested a review from shmpwk November 27, 2023 01:51
@tkimura4 tkimura4 changed the base branch from beta/v0.10.5 to beta/v0.10.6 November 27, 2023 08:58
@tkimura4 tkimura4 marked this pull request as ready for review November 27, 2023 08:58
@tkimura4 tkimura4 changed the title Hotfix/cuda preprocess perf(image_projection_based_fusion,lidar_centerpoint): add cuda preprocess Nov 27, 2023
@tkimura4 tkimura4 merged commit 192d72d into beta/v0.10.6 Nov 27, 2023
@tkimura4 tkimura4 deleted the hotfix/cuda-preprocess branch November 27, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants