Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(detection_by_tracker): add ignore option for each label #1033

Merged

Conversation

badai-nguyen
Copy link

@badai-nguyen badai-nguyen commented Nov 22, 2023

Hotfix autowarefoundation#5473 to beta/v0.11.1

  • fix(detection_by_tracker): add ignore for each class

  • fix: launch


Description

塩尻と小松では、Detection_by_trackerは車に対してOff、歩行者に対してOnにした方が検知結果はより安定になる傾向であるので、各のクラスをOn/Off機能を追加。
関係チケット:
https://tier4.atlassian.net/browse/RT0-29682
https://tier4.atlassian.net/browse/RT0-29721

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…foundation#5473)

* fix(detection_by_tracker): add ignore for each class

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* fix: launch

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

---------

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Copy link

@TomohitoAndo TomohitoAndo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed perception modules work on logging simulator.
image

Parameters are set properly.

$ ros2 param dump /perception/object_recognition/detection/detection_by_tracker/detection_by_tracker_node
/perception/object_recognition/detection/detection_by_tracker/detection_by_tracker_node:
  ros__parameters:
    qos_overrides:
      /clock:
        subscription:
          depth: 1
          durability: volatile
          history: keep_last
          reliability: best_effort
      /parameter_events:
        publisher:
          depth: 1000
          durability: volatile
          history: keep_last
          reliability: reliable
    tracker_ignore_label:
      BICYCLE: false
      BUS: false
      CAR: true
      MOTORCYCLE: false
      PEDESTRIAN: false
      TRAILER: false
      TRUCK: false
      UNKNOWN: true
    use_sim_time: true

@badai-nguyen badai-nguyen merged commit b94aaa3 into beta/v0.11.1 Nov 22, 2023
@badai-nguyen badai-nguyen deleted the dai/detection_by_tracker_class_off_option branch November 22, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants