feat: load global parameter #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
yukkysaito
reviewed
Feb 24, 2022
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
yukkysaito
previously approved these changes
Feb 24, 2022
|
@wep21 Can you change in the perception.launch? |
kenji-miyake
previously approved these changes
Feb 24, 2022
|
Also, considering this use case, it might be useful if we put parameters under |
Sure! |
Exactly |
|
Currently , do we not add vehicle_info namespace? |
No, we don't. |
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
fixed at de2fb8b |
Oh...Seriously |
kenji-miyake
approved these changes
Feb 24, 2022
|
@yukkysaito Yes because there are no conflicts of parameter names. |
|
ops, I deleted comment |
8 tasks
7 tasks
h-ohta
pushed a commit
that referenced
this pull request
Nov 22, 2022
* sync develop for main (#46) * use dual return outlier filter for x2(#24) * expand crop area (#26) Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com> Co-authored-by: Shinnosuke Hirakawa <8327162+0x126@users.noreply.github.com> * Bump streetsidesoftware/cspell-action from 1.3.4 to v1 (#50) * Bump streetsidesoftware/cspell-action from 1.3.4 to 1.3.6 Bumps [streetsidesoftware/cspell-action](https://github.com/streetsidesoftware/cspell-action) from 1.3.4 to 1.3.6. - [Release notes](https://github.com/streetsidesoftware/cspell-action/releases) - [Changelog](https://github.com/streetsidesoftware/cspell-action/blob/main/CHANGELOG.md) - [Commits](streetsidesoftware/cspell-action@v1.3.4...v1.3.6) --- updated-dependencies: - dependency-name: streetsidesoftware/cspell-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Update spell_check_pr.yml Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com> Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com> Co-authored-by: Shinnosuke Hirakawa <8327162+0x126@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
h-ohta
pushed a commit
that referenced
this pull request
Nov 22, 2022
* feat: load global parameter Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * ci: run pre-commit Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * refactor: address review Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * chore: cosmetic change Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to autowarefoundation/autoware.universe#437