Polish README and introduction to glue #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennybc
commented
Aug 27, 2024
|
|
||
| `glue_data()` is very natural to use with the pipe: | ||
|
|
||
| ```{r, eval = getRversion() >= "4.1.0"} |
There was a problem hiding this comment.
I do need to keep this from executing on older versions of R.
| The data-masking feature of `mutate()` means the columns of the target data frame are "in scope" for a `glue()` call: | ||
|
|
||
| ```r | ||
| library(dplyr) |
There was a problem hiding this comment.
This has to be a fixed chunk, given the use of dplyr, which is a drag. But I want to show this.
| glue_sql()\` makes constructing SQL statements safe and easy Use | ||
| backticks to quote identifiers, normal strings and numbers are quoted | ||
| appropriately for your backend. | ||
| glue has explicit support for constructing SQL statements. |
There was a problem hiding this comment.
I really haven't touched this section personally.
There was a problem hiding this comment.
It almost feels like this whole section should be moved to a new SQL-focused vignette.
hadley
approved these changes
Aug 28, 2024
Co-authored-by: Hadley Wickham <h.wickham@gmail.com>
Co-authored-by: Hadley Wickham <h.wickham@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to the cumulative work of 2 tidy dev days, glue has gotten a "get started" style vignette. This PR is me continuing to polish the README and that vignette.