Make unterminated quotes error (#226)

Co-authored-by: Jim Hester <james.f.hester@gmail.com>
tidyverse · Sep 27, 2021 · 9e5c656 · 9e5c656
1 parent 5673c06
commit 9e5c656
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 0 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,6 @@
 # glue 1.4.2
 
+* Unterminated quotes in glue expressions now throw an error (#226, @gaborcsardi)
 * `glue_safe()` gives a slightly nicer error message
 * The required version of R is now 3.2 (#189)
 * `glue_sql()` now collapses `DBI::SQL()` elements correctly (#192 @shrektan)

diff --git a/src/glue.c b/src/glue.c
@@ -176,6 +176,12 @@ SEXP glue_(SEXP x, SEXP f, SEXP open_arg, SEXP close_arg) {
   if (state == delim) {
     free(str);
     Rf_error("Expecting '%s'", close);
+  } else if (state == single_quote) {
+    free(str);
+    Rf_error("Unterminated quote (')");
+  } else if (state == double_quote) {
+    free(str);
+    Rf_error("Unterminated quote (\")");
   }
 
   free(str);

diff --git a/tests/testthat/test-glue.R b/tests/testthat/test-glue.R
@@ -424,3 +424,8 @@ test_that("+ method for glue works", {
   x <- 1
   expect_identical(glue("x = ") + "{x}", glue("x = {x}"))
 })
+
+test_that("unterminated quotes are error", {
+  expect_error(glue("{this doesn\"t work}"), "Unterminated quote")
+  expect_error(glue("{this doesn't work}"), "Unterminated quote")
+})