Rewrite between() with vctrs
#6260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadley
approved these changes
May 8, 2022
- Supports more input types - No longer requires scalar left/right - Bounds are cast to type of `x` - Bounds are recycled to size of `x`
b3a3dc0 to
ed578c7
Compare
Since it seems like the cause of most of the revdep failures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6183
xxSee also my funs PR where I discuss the enhancements I made there and talk a little about performance tidyverse/funs#78. This is basically a port of that.
Revdep run shows 6 failures that seem to be related to
between()getting a little stricter (related to the fact thatleftandrightare cast to the type ofx, so you can't dobetween(1L, -Inf, Inf), for example). It says 9 failures but 3 are related to a failing internet resource. This seems reasonable.Might need to adjust the NEWS bullet to talk more about the strictness.