Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip check_cols in gennerate when type = 'bootstrap' #442

Closed
wants to merge 1 commit into from

Conversation

liubao210
Copy link

@liubao210 liubao210 commented Mar 17, 2022

When type = "bootstrap", the variable parameter is not required? According to the existing code, executing this statement will report an error generate(mtcars, reps = 10, type = 'bootstrap') So I made changes to skip check_cols when type = "bootstrap"

@ismayc ismayc requested a review from simonpcouch April 4, 2022 17:55
@simonpcouch
Copy link
Collaborator

Thanks for the PR! Can you please confirm that this PR doesn't duplicate #425 and, if not, provide a minimal reprex (reproducible example) demonstrating the issue that your PR addresses and how the package's behavior will change?

@liubao210
Copy link
Author

Thanks for the PR! Can you please confirm that this PR doesn't duplicate #425 and, if not, provide a minimal reprex (reproducible example) demonstrating the issue that your PR addresses and how the package's behavior will change?

Before this change I execute the code mtcars |> generate(reps = reps, type = "bootstrap"),got "error: The variables argument should be one or more unquoted variable names (not strings in quotation marks)."
because i have to

Thanks for the PR! Can you please confirm that this PR doesn't duplicate #425 and, if not, provide a minimal reprex (reproducible example) demonstrating the issue that your PR addresses and how the package's behavior will change?

Before this change I execute the code mtcars |> generate(reps = reps, type = "bootstrap"), got "error: The variables argument should be one or more unquoted variable names (not strings in quotation marks)."
I have to assign a value to variables mtcars |> generate(reps = reps, type = "bootstrap", variables = cyl), which is useless? so i made this change,Thanks!

@simonpcouch
Copy link
Collaborator

Ah, I see. I think skipping check_cols entirely is a bit too blunt of an approach, but have opened an issue #448 for more discussion. Thanks again for the PR. :)

@github-actions
Copy link

github-actions bot commented May 4, 2022

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators May 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants