Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handling columns named x #434

Merged
merged 6 commits into from
Dec 31, 2021
Merged

handling columns named x #434

merged 6 commits into from
Dec 31, 2021

Conversation

simonpcouch
Copy link
Collaborator

Fixes #431! Updated NEWS and added additional unit testing, as well—related to #299 and issues linked there.

@mine-cetinkaya-rundel
Copy link
Collaborator

@simonpcouch The implementation looks good to me, but any idea why the action checks are failing?

@simonpcouch
Copy link
Collaborator Author

Great! They're failing re: #428. I'll rebase here and on #435 and #437 once I track down a fix for that (hopefully today).

@simonpcouch simonpcouch merged commit 9a9e74c into main Dec 31, 2021
@simonpcouch simonpcouch deleted the scope-x-431 branch December 31, 2021 19:10
@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reproducible error
2 participants