Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSS paper #401

Merged
merged 13 commits into from
Aug 20, 2021
Merged

JOSS paper #401

merged 13 commits into from
Aug 20, 2021

Conversation

simonpcouch
Copy link
Collaborator

@simonpcouch simonpcouch commented Jun 24, 2021

Hi all! @andrewpbray, @ismayc, @echasnovski, @beanumber, @mine-cetinkaya-rundel

After these last two active PRs are addressed in the coming weeks, we hope to submit v1.0.0 to CRAN. After that, we hope to submit a short paper on infer to JOSS. I’ve PRed a draft to figs/paper—edits/suggestions are more than welcome. JOSS papers are usually pretty minimal, so there’s not a ton of content here.

Submission guidelines: https://joss.readthedocs.io/en/latest/submitting.html

Review checklist: https://joss.readthedocs.io/en/latest/review_checklist.html

Review criteria: https://joss.readthedocs.io/en/latest/review_criteria.html

Some recent R package papers (with links to the GH issue where the reviews take place):

If folks have a moment, I’d especially appreciate an eye for whether the “Underlying Principles” section speaks well to the big ideas of the package, as a contributor who was not around at the very beginning of the project.:slightly_smiling_face:

figs/paper/paper.Rmd Outdated Show resolved Hide resolved
figs/paper/paper.Rmd Outdated Show resolved Hide resolved
figs/paper/paper.Rmd Outdated Show resolved Hide resolved
figs/paper/paper.Rmd Outdated Show resolved Hide resolved
figs/paper/paper.Rmd Outdated Show resolved Hide resolved
figs/paper/paper.Rmd Outdated Show resolved Hide resolved
figs/paper/paper.Rmd Outdated Show resolved Hide resolved
figs/paper/paper.bib Outdated Show resolved Hide resolved
@beanumber
Copy link
Contributor

This looks GREAT! Nice work @simonpcouch !!

@simonpcouch
Copy link
Collaborator Author

Much appreciated, @beanumber! Will get started on these edits right now.

Copy link
Collaborator

@mine-cetinkaya-rundel mine-cetinkaya-rundel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great. A few minor and one more major rewording suggestion.

figs/paper/paper.Rmd Outdated Show resolved Hide resolved
figs/paper/paper.Rmd Outdated Show resolved Hide resolved
figs/paper/paper.Rmd Show resolved Hide resolved
figs/paper/paper.Rmd Outdated Show resolved Hide resolved
@simonpcouch
Copy link
Collaborator Author

Super helpful, thank you. :-)

Copy link
Collaborator

@ismayc ismayc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, @simonpcouch! I added a few suggestions and my thoughts.

figs/paper/paper.Rmd Outdated Show resolved Hide resolved
figs/paper/paper.Rmd Outdated Show resolved Hide resolved
figs/paper/paper.Rmd Outdated Show resolved Hide resolved
figs/paper/paper.Rmd Show resolved Hide resolved
@simonpcouch
Copy link
Collaborator Author

Thank you, @ismayc! Apologies for the delay, been away for a bit. Will add your remaining revisions now!

Copy link
Collaborator

@andrewpbray andrewpbray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

figs/paper/paper.Rmd Outdated Show resolved Hide resolved
@simonpcouch
Copy link
Collaborator Author

v1.0.0 is on CRAN! Yippee!🎊

This puts in a good position to move forward with the JOSS paper. Wanted to make sure all authors are on board with this draft before submitting to JOSS—if you're happy with where the paper is at, could you thumbs up this comment? cc @andrewpbray, @ismayc, @echasnovski, @beanumber, @mine-cetinkaya-rundel

Much appreciated, yall.🙂

@beanumber
Copy link
Contributor

Great work @simonpcouch ! Thanks for all you've put into this!

Whedon looks for a `paper.md` or `paper.tex` in the repo, and errors if it finds both
@simonpcouch simonpcouch merged commit 71bfd51 into master Aug 20, 2021
@simonpcouch simonpcouch deleted the joss branch August 20, 2021 12:14
@simonpcouch
Copy link
Collaborator Author

Okay, submitted! Merged earlier than I would a feature as JOSS requires that the paper draft is on the default branch—I'll plan on tagging a GitHub-only v1.0.1 release if the paper is accepted. :-)

@github-actions
Copy link

github-actions bot commented Sep 4, 2021

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants