In calculate, should F and Chisq stats be lower case?

[davidhodge931]

Unless there is some reason I'm unaware of, I think it would be easier to remember if all stats were lower case, i.e. if F & Chisq were f and chisq

[simonpcouch]

#37 (comment) might be relevant here.

One solution here could be to check if the inputted stat matches one of the options tolower()ed--in that case, maybe:

a) message that chisq/f was replaced with Chisq/F and move forward? Or...
b) continue to error out but do so more informatively? This approach feels more tidy, I think.

[echasnovski]

I have the same reasoning. If designing from beginning I'd make them all lowercase, but now making them lowercase will break existing code. Allow case insensitive matching seems too permissive.

I added a "standard" tidyverse way of matching argument with a predefined set: it will error if argument is not in the set and suggest an alternative in case of a "not very big" typo. Currently this doesn't work with single letter values, but might be fixed in the future.

@ismayc, do you have any strong opinions here?

[ismayc]

I agree with Simon's suggestion. Provide a message but allow either case to work

[ismayc]

F and Chisq were chosen because capital letters were common in historical examples.

[echasnovski]

Thanks for suggestion. Implemented both current and lower case via allowed aliases.

[github-actions]

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.