make tfb_fpc work with (small amounts of) missingness #81
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see docs for fpc_wsvd for details.
seems useful for applications, probably only works well in cases where simply replacing missings with interpolated values before FPCA would work about as well.
but at least this means one can now simply do
cca_pc <- tfb_fpc(tidyfun::dti_df$cca)
, e.g., without worrying about that .5% of missing data...@jeff-goldsmith @m-muecke @sebffischer
if you have time, could you read the docs / try this out on some data and LMK what's missing/broken?
somewhat related to #10 as well - can now do tfb_fpc for irregular data, in principle