Timob 17016 new #6020
Closed
Timob 17016 new #6020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[TIMOB-17532] Updated ioslib to 0.2.1 which fixes some debug output.
[TIMOB-17525] Added support for Android L.
…25_3_4_X Revert "[TIMOB-17525] Added support for Android L."
[TIMOB-17604] Fixed typo when referencing a device.
|
I think this might have too many commits in it. |
|
Looks like this PR has another PR's commits as well. |
| @@ -35,8 +35,10 @@ public void setTab(TiUIActionBarTab tab) { | |||
|
|
|||
| @Override | |||
| public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) { | |||
|
|
|||
| return tab.getContentView(); | |||
| if (tab != null) { | |||
There was a problem hiding this comment.
Under what circumstance would this be null?
There was a problem hiding this comment.
This is already merged in master and in 3_4_X by #5651.
@hieupham007 - it is null for the zombie fragments that are retained in the fragment manager (and NPE happens without the test), and are recreated (and onCreateView is called) if the activity was destroyed and then recreated. This is fixed in my latest PR which ensures that fragments are reused: #6008
|
This PR should be committing for 3.4.X, but is commiting to master branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-17016
Null check added to prevent crash.
Based on 3_4_X.