Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android): update gradle to 7.4.2 #13443

Merged
merged 8 commits into from
May 17, 2022
Merged

feat(android): update gradle to 7.4.2 #13443

merged 8 commits into from
May 17, 2022

Conversation

m1ga
Copy link
Contributor

@m1ga m1ga commented May 12, 2022

resolves #13442

  • update gradle tools to 7.4.2 (from 7.1.0)
  • minor update to gradle build tools to 7.0.4 (from 7.0.1)
  • minor update to kotlin to 1.6.21 (from 1.6.10)
  • will give us Java 17 support (starting with 7.3.3; did all test with 7.3.3 first, then tested 7.4.2 and it worked too)
  • added a section to the README how to update gradle

Tests I've did:

Javac 11

  • javac --version -> 11.0.15
  • build SDK
  • build module with 11.0.0 -> run it in app with 10.1.1
  • build app with 11.0.0

Javac 17

  • javac --version -> 17.0.3
  • build SDK
  • build module with 11.0.0 -> run it in app with 10.1.1
  • bulid app with 11.0.0
  • run whole test suite (Android 13 emulator)
  • run ./gradlew in build/android folder to check it shows version 7.4.2
  • hyperloop examples
  • build kotlin module

Note:

@m1ga m1ga changed the title feat(android): update gradle to 7.3.3 feat(android): update gradle to 7.4.2 May 12, 2022
@jquick-axway
Copy link
Contributor

jquick-axway commented May 12, 2022

Here's an example on how I updated gradle (and things related to it) in the past, if you think it helps. I usually test with hyperloop-examples to make sure it doesn't break hyperloop.
#12821

I'm pretty sure the newest JDK breaks kotlin too. You might want to upgrade the kotlin plugin as well. :)
I hope this helps!

@m1ga
Copy link
Contributor Author

m1ga commented May 12, 2022

Hyperloop examples still work fine with this setup and I can compile my kotlin mlkit module + the test app. The :app:desugarDebugFileDependencies part takes a bit longer now but when I do a store build the APK is 3mb smaller.

edit: but I'll test the latest kotlin version. Might not be bad to update that

Copy link
Contributor

@caspahouzer caspahouzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caspahouzer caspahouzer merged commit 122fa59 into master May 17, 2022
@caspahouzer caspahouzer deleted the gradleUpdate branch May 17, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android: upgrade gradle version
3 participants